XML containing xsi:nil is improperly parsed #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for reporting this -- I'll merge the test, and refactor it to go under |
cowtowncoder
pushed a commit
that referenced
this pull request
Oct 23, 2019
cowtowncoder
added a commit
that referenced
this pull request
Oct 23, 2019
cowtowncoder
added a commit
that referenced
this pull request
Oct 23, 2019
|
Thanks! Sorry, forgot to set the right base branch on the PR, it was supposed to be 2.11 |
|
That's fine: I actually brought it back to 2.10 since it'd be good to fix there, not just 2.11 (although we'll see) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XML containing a nested field with
xsi:nil="true"causes following fields to be deserialized at the wrong hierarchy. I've added a unit test to demonstrate this incorrect behavior.This appears to be a new bug in 2.10.0 as a result of 4938036