New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite Bean Property Introspection logic in Jackson 2.x #4515
Comments
Started reading the code and clearly more of code wrt Creator detection needs to move from But not sure whether to try to move abstractions from Factory part, or rewrite; and whether to try move things incrementally or not. Started removing deprecated methods from code paths, to help isolate actual in-use code. |
If we agree that we have enough test coverage, I guess.... rewrite, move big-step-incrementally? |
@JooHyukKim Yes, I think test coverage is sufficient to allow refactoring. I am struggling at finding the steps tho. Especially in a way that would allow merging 2.18 -> master. And one problem part is that the latest |
Ok one big challenge that is coming up now, looking through functionality in In the meantime I am making small incremental changes, including removal of deprecated code in affected areas. |
Right. Also from my experience, many times it was necessary to both modify existing and add additional "internal" structure to make the code base in better shape. More of "tidy up just before making changes". Just out of curiosity, are we going to introduce |
Not planned yet. I am thinking it should be possible to make things work without fully separate implementation. But of course if it becomes necessary that could be done. At this first I would really want to make existing logic work same as now, but get Creator properties discovered around time others are... so move it out of |
Hmmmh. Despite incremental refactoring, I don't think functional from ... Ok. So, in |
Good progress:
Hoping to solve remaining Record tests, to get first PR merged into 2.18, then master. |
First part of refactoring towards #4515.
Describe your Issue
We need to rewrite the Bean Property introspection (see #3719 for background); and while this is ambitious undertaking, I think it should be done in Jackson 2.x timeframe, not 3.x. That way code remains potentially mergeable from 2.x to 3.x.
The main drivers for rewrite are to solve problems that are difficult if not impossible to solve with the current mechanism:
This issue is an umbrella ticket as refactoring will likely be spread across multiple PRs; they can all refer to this issue,
The text was updated successfully, but these errors were encountered: