Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back Java 22 optimisation in FastDoubleParser #1277

Closed
pjfanning opened this issue Apr 26, 2024 · 1 comment
Closed

Add back Java 22 optimisation in FastDoubleParser #1277

pjfanning opened this issue Apr 26, 2024 · 1 comment
Labels
2.18 Issues planned at earliest for 2.18

Comments

@pjfanning
Copy link
Member

pjfanning commented Apr 26, 2024 •
edited

The pom.xml removes the Java 22 classes for fastdoubleparser. Maven Shade plugin settings. Will also need to add a relocation setting.

It should be safe to add them back now. Build tools have releases that support Java 22 format classes.
@cowtowncoder
Copy link
Member

Let's do that for 2.18, however, to reduce risk for 2.17.1.

cowtowncoder added a commit that referenced this issue Apr 30, 2024
@cowtowncoder
Fix #1277: add JDK 22 optimizations back to FDP
94833ef
@cowtowncoder cowtowncoder mentioned this issue Apr 30, 2024
Merged
@cowtowncoder cowtowncoder added the 2.18 Issues planned at earliest for 2.18 label May 1, 2024
@cowtowncoder cowtowncoder changed the title Add back Java 22 optimisation in fastdoubleparser Add back Java 22 optimisation in FastDoubleParser May 1, 2024
cowtowncoder added a commit that referenced this issue May 1, 2024
@cowtowncoder
Update release notes wrt #1277
02e415e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.18 Issues planned at earliest for 2.18
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cowtowncoder @pjfanning