Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow suppresion of source information in exception messages #1158

Open
jamesagnew opened this issue Dec 6, 2023 · 2 comments
Open

Allow suppresion of source information in exception messages #1158

jamesagnew opened this issue Dec 6, 2023 · 2 comments

Comments

@jamesagnew
Copy link

This is a follow-on from the discussion in #1151 .

Currently the JsonParser.Feature.INCLUDE_SOURCE_IN_LOCATION setting can be used to choose whether to include source information as a part of the location in JsonProcessingException.

When this is disabled, the message now includes messages such as:

at [Source: REDACTED (`StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION` disabled); line: 4, column: 18]

It would be nice to have configuration that just disables the source entirely from this text blurb, logs and messages don't have a reference to internal implementation details. Ideally this would result in messages more like:

at [line: 4, column: 18]
@pjfanning
Copy link
Member

pjfanning commented Dec 6, 2023

To be honest, I think we could just change this in 2.17 to leave out the Source: REDACTED (StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION disabled); if treamReadFeature.INCLUDE_SOURCE_IN_LOCATION is disabled. That is, I don't see the need to make this even more configurable.

@cowtowncoder
Copy link
Member

My worry is simply that if any references are removed, by default, developers are not even aware of possibility of including source as part of Location information. And so we are going to be hit by requests to start including source to show "where is the problem?" (esp. since older versions include it, for some sources).

Put another way: reference to StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION is very much intentional hint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants