Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async parsing turns " inside element content into apostrophe #78

Closed
jphelp32 opened this issue Mar 24, 2022 · 4 comments
Closed

Async parsing turns " inside element content into apostrophe #78

jphelp32 opened this issue Mar 24, 2022 · 4 comments
Milestone

Comments

@jphelp32
Copy link

This issue does not occur in 1.2.2. It is present in 1.3.1. I'm told it's also present in 1.3.0, but I haven't confirmed that myself.

I think I can see the code that's doing this, and that it's been in place for a long time. Wondering if maybe other fixes in 1.3.x have caused this long-standing bug to surface where before it was hidden?

See:

Also two locations in AsyncByteArrayScanner.java

@jphelp32
Copy link
Author

@cowtowncoder any thoughts on this? if accurate, it seems like a pretty severe issue. Could a fix be released in the near term?

@cowtowncoder
Copy link
Member

@jphelp32 Yes, if someone provides a patch it could definitely be released. I do not have time to work on Aalto right now but can always help others with PRs.

@cowtowncoder cowtowncoder added this to the 1.3.2 milestone Apr 25, 2022
@cowtowncoder
Copy link
Member

Ok, I managed to find some time to work on this: fix itself is not a problem (trivial copy-paste problem) but just had to go and find a test to modify to verify goodness of fix for both input sources (byte array and ByteBuffer backed).

I'll release 1.3.2 soon, maybe today, with this fix. Thank you again for reporting the issue @jphelp32 !

@jphelp32
Copy link
Author

Thanks @cowtowncoder !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants