From 74b3805f6f8ed123c82cbe29c82e51d825a81f81 Mon Sep 17 00:00:00 2001 From: Daniel Schmelz Date: Thu, 27 Jan 2022 20:29:28 +0100 Subject: [PATCH 1/3] fix docblock return type --- src/Faker/Provider/cs_CZ/Person.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Faker/Provider/cs_CZ/Person.php b/src/Faker/Provider/cs_CZ/Person.php index 1f7774e05f..acf06a868e 100644 --- a/src/Faker/Provider/cs_CZ/Person.php +++ b/src/Faker/Provider/cs_CZ/Person.php @@ -430,7 +430,7 @@ class Person extends \Faker\Provider\Person * @param int $minAge minimal age of "generated person" in years * @param int $maxAge maximal age of "generated person" in years * - * @return czech birth number + * @return string birth number */ public function birthNumber($gender = null, $minAge = 0, $maxAge = 100, $slashProbability = 50) { From 94b45493542a390bef365dfe11ed32f24cd899a7 Mon Sep 17 00:00:00 2001 From: Daniel Schmelz Date: Thu, 27 Jan 2022 20:39:17 +0100 Subject: [PATCH 2/3] fix docblock return type --- src/Faker/Provider/cs_CZ/Person.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Faker/Provider/cs_CZ/Person.php b/src/Faker/Provider/cs_CZ/Person.php index acf06a868e..6e2bab1375 100644 --- a/src/Faker/Provider/cs_CZ/Person.php +++ b/src/Faker/Provider/cs_CZ/Person.php @@ -430,7 +430,7 @@ class Person extends \Faker\Provider\Person * @param int $minAge minimal age of "generated person" in years * @param int $maxAge maximal age of "generated person" in years * - * @return string birth number + * @return string czech birth number */ public function birthNumber($gender = null, $minAge = 0, $maxAge = 100, $slashProbability = 50) { From f040f2ba7056390dd5c1a04b32b934794a002e56 Mon Sep 17 00:00:00 2001 From: Daniel Schmelz Date: Thu, 27 Jan 2022 20:49:50 +0100 Subject: [PATCH 3/3] fix phpstan, psalm --- phpstan-baseline.neon | 10 ---------- psalm.baseline.xml | 9 --------- 2 files changed, 19 deletions(-) diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon index 69f1d7d141..36b11fd9df 100644 --- a/phpstan-baseline.neon +++ b/phpstan-baseline.neon @@ -829,16 +829,6 @@ parameters: count: 2 path: src/Faker/Provider/cs_CZ/DateTime.php - - - message: "#^Method Faker\\\\Provider\\\\cs_CZ\\\\Person\\:\\:birthNumber\\(\\) should return Faker\\\\Provider\\\\cs_CZ\\\\czech but returns string\\.$#" - count: 1 - path: src/Faker/Provider/cs_CZ/Person.php - - - - message: "#^Return typehint of method Faker\\\\Provider\\\\cs_CZ\\\\Person\\:\\:birthNumber\\(\\) has invalid type Faker\\\\Provider\\\\cs_CZ\\\\czech\\.$#" - count: 1 - path: src/Faker/Provider/cs_CZ/Person.php - - message: "#^Static call to instance method Faker\\\\Provider\\\\cs_CZ\\\\Person\\:\\:birthNumber\\(\\)\\.$#" count: 2 diff --git a/psalm.baseline.xml b/psalm.baseline.xml index 04ca4ec424..3fd3b88614 100644 --- a/psalm.baseline.xml +++ b/psalm.baseline.xml @@ -181,19 +181,10 @@ - - $birthNumber - - - czech - static::birthNumber(static::GENDER_FEMALE) static::birthNumber(static::GENDER_MALE) - - czech -