Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Use .yaml instead of .yml as extension #569

Merged
merged 1 commit into from Dec 8, 2022
Merged

Fix: Use .yaml instead of .yml as extension #569

merged 1 commit into from Dec 8, 2022

Conversation

localheinz
Copy link
Member

What is the reason for this PR?

  • use .yaml instead of .yml as extension

Author's checklist

Summary of changes

Review checklist

  • All checks have passed
  • Changes are approved by maintainer

@pimjansen
Copy link

pimjansen commented Dec 8, 2022 •
edited

This is good. The suggested syntax is yaml.

See https://yaml.org/faq.html

The reason why yml exists is due certain filesystems only supported 3 char extensions. However this is long gone

@localheinz localheinz merged commit e5e8400 into FakerPHP:main Dec 8, 2022
@localheinz localheinz deleted the fix/yaml branch December 8, 2022 21:08
@localheinz
Copy link
Member Author

Thank you, @pimjansen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pimjansen pimjansen pimjansen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@localheinz @pimjansen