run 'mkdir' only if the directory doesn't exist yet #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please put a space after the exclamation mark, and perhaps use Also, |
added 2 commits
June 16, 2022 18:59
fgaroby
force-pushed
the
fix_mkdir_cs-fixer
branch
from
059b287
to
28950e1
Compare
|
Thanks! |
bram-pkg
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the reason for this PR?
Author's checklist
Summary of changes
When we run the
make cscommand twice, this error occurs:In .php-cs-fixer.dist.php line 16: [ErrorException] mkdir(): File exists Exception trace: at /home/fgaroby/workspace/Faker/.php-cs-fixer.dist.php:16 {closure}() at n/a:n/a mkdir() at /home/fgaroby/workspace/Faker/.php-cs-fixer.dist.php:16 include() at /home/fgaroby/workspace/Faker/vendor-bin/php-cs-fixer/vendor/friendsofphp/php-cs-fixer/src/Console/ConfigurationResolver.php:946 PhpCsFixer\Console\ConfigurationResolver::separatedContextLessInclude() at /home/fgaroby/workspace/Faker/vendor-bin/php-cs-fixer/vendor/friendsofphp/php-cs-fixer/src/Console/ConfigurationResolver.php:267 PhpCsFixer\Console\ConfigurationResolver->getConfig() at /home/fgaroby/workspace/Faker/vendor-bin/php-cs-fixer/vendor/friendsofphp/php-cs-fixer/src/Console/ConfigurationResolver.php:598 PhpCsFixer\Console\ConfigurationResolver->getFormat() at /home/fgaroby/workspace/Faker/vendor-bin/php-cs-fixer/vendor/friendsofphp/php-cs-fixer/src/Console/ConfigurationResolver.php:444 PhpCsFixer\Console\ConfigurationResolver->getReporter() at /home/fgaroby/workspace/Faker/vendor-bin/php-cs-fixer/vendor/friendsofphp/php-cs-fixer/src/Console/Command/FixCommand.php:261 PhpCsFixer\Console\Command\FixCommand->execute() at /home/fgaroby/workspace/Faker/vendor-bin/php-cs-fixer/vendor/symfony/console/Command/Command.php:255 Symfony\Component\Console\Command\Command->run() at /home/fgaroby/workspace/Faker/vendor-bin/php-cs-fixer/vendor/symfony/console/Application.php:1009 Symfony\Component\Console\Application->doRunCommand() at /home/fgaroby/workspace/Faker/vendor-bin/php-cs-fixer/vendor/symfony/console/Application.php:273 Symfony\Component\Console\Application->doRun() at /home/fgaroby/workspace/Faker/vendor-bin/php-cs-fixer/vendor/friendsofphp/php-cs-fixer/src/Console/Application.php:97 PhpCsFixer\Console\Application->doRun() at /home/fgaroby/workspace/Faker/vendor-bin/php-cs-fixer/vendor/symfony/console/Application.php:149 Symfony\Component\Console\Application->run() at /home/fgaroby/workspace/Faker/vendor-bin/php-cs-fixer/vendor/friendsofphp/php-cs-fixer/php-cs-fixer:115 fix [--path-mode PATH-MODE] [--allow-risky ALLOW-RISKY] [--config CONFIG] [--dry-run] [--rules RULES] [--using-cache USING-CACHE] [--cache-file CACHE-FILE] [--diff] [--format FORMAT] [--stop-on-violation] [--show-progress SHOW-PROGRESS] [--] [<path>...] make: *** [Makefile:13 : cs] Error 1This PR checks if the directory doesn't exit yet.
Review checklist