Add Microsoft Edge User Agent

[dutchie027]

What is the reason for this PR?

This pull request adds the MS Edge User Agent.

• A new feature
• Fixed an issue (resolve #ID)

Author's checklist

• Follow the Contribution Guide
• New features and changes are documented - PR#64

Summary of changes

The Microsoft Edge User Agent was added in the User Agent Provider. It can generate an Edge UA for Windows, Linux, Mac and also iOS. To support iOS, the iOS device function was also added to the User Agent Provider.

A test was written to search for "Edg" when calling this user agent as that is the commonality among all Ednge UAs. (Edg, EdgA and EdgiOS respectively are the three different "distinct" Edge UAs.)

PR for documentation submitted

Review checklist

• All checks have passed
• Changes are approved by maintainer

[bram-pkg]

Please revert the change in the Person provider. Otherwise this looks good.

[dutchie027]

should I push the person change in another commit?

[pimjansen]

should I push the person change in another commit?

No we are not just randomly adding names since people want their own

[pimjansen]

Do we have some source refs on how these look for Edge? PR looks fine but have to cross check to be sure

[dutchie027]

Here is my current user agent:

Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/99.0.4844.74 Safari/537.36 Edg/99.0.1150.46

The latest user agents for Edge

[pimjansen]

Ok thanks for the list, looks good. What still is missing is the addition in the Generator phpdoc. Since all calls to legacy are still made using a __call it is required.

[dutchie027]

Copy. Didn't see that in the "Best Practices" area. Should be in Generator.php now for doc and autocompletion.

[pimjansen]

Copy. Didn't see that in the "Best Practices" area. Should be in Generator.php now for doc and autocompletion.

Yeah it is until we reach v2. Mostly because static type tools like psalm and phpstan complain if it is not.

Will give it a last review tomorrow but i think we are good to go. Maybe @bram-pkg finds some time earlier though

[bram-pkg]

Fixed that last style error for you.

[dutchie027]

Thanks. Switching between github.dev and trying to lint using a remote desktop connection makes for a lot of errors it seems :(

[bram-pkg]

The problem probably was that php-cs-fixer doesn't like linting between different versions of PHP. Try running it on PHP 7.1 next time :)

…

On Thu, 24 Mar 2022 at 19:50, dutchie027 ***@***.***> wrote: Thanks. Switching between github.dev and trying to lint using a remote desktop connection makes for a lot of errors it seems :( — Reply to this email directly, view it on GitHub <#464 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADFQHIZ6YO43ZP7W36WY5HTVBS2OLANCNFSM5RMSSWNQ> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

[robbinjanssen]

There is a bug in this PR, i've fixed it in #469

Update; a little more details would be nice: The static is called edge but the method is called msedge(). When calling a random userAgent it tries to call edge() which doesn't exist. The PR renames edge to msedge