Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added excludes for BC #432

Merged
merged 1 commit into from Jan 23, 2022
Merged

Conversation

pimjansen
Copy link

@pimjansen pimjansen commented Jan 23, 2022

What is the reason for this PR?

Exclude the BC issues for experimental features

  • A new feature
  • Fixed an issue (resolve #ID)

Author's checklist

Review checklist

  • All checks have passed
  • Changes are approved by maintainer

@pimjansen pimjansen force-pushed the feature/bc-check-fixes branch 2 times, most recently from 76e852b to 5fe93b4 Compare January 23, 2022 09:41
@pimjansen
Copy link
Author

Hmm something still wrong with the new regexes though, have to review locally

@pimjansen
Copy link
Author

@GrahamCampbell @bram-pkg ready for review. After that the broken builds can be rebased on main.

@bram-pkg bram-pkg merged commit 4e63216 into FakerPHP:main Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants