Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG.md #429

Merged
merged 3 commits into from Jan 23, 2022
Merged

Update CHANGELOG.md #429

merged 3 commits into from Jan 23, 2022

Conversation

bram-pkg
Copy link
Member

No description provided.

@GrahamCampbell
Copy link
Member

BC Check needs fixing.

@bram-pkg
Copy link
Member Author

BC Check needs fixing.

Those changes were made in experimental classes.

@GrahamCampbell
Copy link
Member

In which case the bc yml config file needs adjusting to permit the change. The CI should never be in a failing state. I have adjusted the config to mandate the passing of that job to prevent such a mistake in the future.

@bram-pkg
Copy link
Member Author

Rebased on main. Ready for review now.

@bram-pkg bram-pkg merged commit 2e77a86 into main Jan 23, 2022
@bram-pkg bram-pkg deleted the update-changelog branch January 23, 2022 17:56
krsriq pushed a commit to krsriq/Faker that referenced this pull request Jan 23, 2022
* Update CHANGELOG.md

* Update CHANGELOG.md

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants