Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Person->name was missing string return type #424

Merged
merged 1 commit into from Jan 20, 2022
Merged

Person->name was missing string return type #424

merged 1 commit into from Jan 20, 2022

Conversation

pimjansen
Copy link

@pimjansen pimjansen commented Jan 20, 2022 •
edited

What is the reason for this PR?

Missing return type for PersonExtension::name

  • A new feature
  • Fixed an issue (resolve #ID)

Author's checklist

Summary of changes

added return type

Review checklist

  • All checks have passed
  • Changes are approved by maintainer

@bram-pkg bram-pkg merged commit 34d231f into FakerPHP:main Jan 20, 2022
@pimjansen pimjansen deleted the feature/missing-return-type branch January 20, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bram-pkg bram-pkg bram-pkg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pimjansen @bram-pkg