Skip to content

Restore missing union types #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Restore missing union types #352

merged 1 commit into from
Jul 13, 2021

Conversation

shalvah
Copy link

@shalvah shalvah commented Jul 13, 2021

What is the reason for this PR?

Fixes #349

Author's checklist

Summary of changes

As described in the linked issue, this PR restores the Union types that were incorrectly changed in an earlier PR.

Review checklist

  • All checks have passed
  • Changes are approved by maintainer

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@bram-pkg bram-pkg merged commit a1be2d3 into FakerPHP:main Jul 13, 2021
@bram-pkg
Copy link
Member

Looks good to me, thanks a lot!

@shalvah shalvah deleted the patch-1 branch July 13, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect static analysis types (all union types missing)
2 participants