Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the documentation page about SideWaffle #1753

Closed
thomaslevesque opened this issue Jan 25, 2020 · 3 comments · Fixed by #1754
Closed

Remove the documentation page about SideWaffle #1753

thomaslevesque opened this issue Jan 25, 2020 · 3 comments · Fixed by #1754
Labels
📚 documentation
Milestone
6.0.1

Comments

@thomaslevesque
Copy link
Member

The FakeItEasy snippets provided by SideWaffle, which are mentioned in the documentation, are outdated (last update was in 2016). In particular, call assertions that specify the number of calls use the retired Repeated API (so our doc is lying, since it shows the new API).

We should either:

  • Update the snippets in SideWaffle. Easily done, but I'm not sure it's worth the trouble, because
    • there has been no new releases for almost 4 years, so I don't think it's still maintained
    • it doesn't support VS2017 and 2019
  • Update the docs to mention that some snippets are outdated
  • Remove the page entirely
@blairconrad
Copy link
Member

blairconrad commented Jan 25, 2020 •
edited

You had me at "SideWaffle". IMO,

Remove the page entirely

@thomaslevesque
Copy link
Member Author

Agreed

@thomaslevesque thomaslevesque mentioned this issue Jan 25, 2020
Merged
@blairconrad blairconrad added this to the vNext milestone Jan 25, 2020
@blairconrad blairconrad changed the title Remove the documentation page about SideWaffle, or update SideWaffle snippets Remove the documentation page about SideWaffle Jan 26, 2020
@afakebot
Copy link

This change has been released as part of FakeItEasy 6.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
📚 documentation
Projects
None yet
Milestone
6.0.1
Development

Successfully merging a pull request may close this issue.

Remove docs about SideWaffle snippets thomaslevesque/FakeItEasy
3 participants
@thomaslevesque @blairconrad @afakebot