Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #1709 - now targeting 5.x support #1712

Merged
merged 5 commits into from Nov 24, 2019
Merged

Fix for issue #1709 - now targeting 5.x support #1712

merged 5 commits into from Nov 24, 2019

Conversation

asgerhallas
Copy link
Contributor

The support/5.x branch does not compile for me, as I have no GetTypeInformation() method for System.Type. I guess it should be GetTypeInfo()... or am I missing something?

@asgerhallas
Copy link
Contributor Author

Sorry for removing the other PR, I just needed to get my own forks master back to match yours... so I wouldn't get in trouble later.

@asgerhallas
Copy link
Contributor Author

@thomaslevesque your last comments are included in the new PR too.

@thomaslevesque
Copy link
Member

The support/5.x branch does not compile for me, as I have no GetTypeInformation() method for System.Type. I guess it should be GetTypeInfo()... or am I missing something?

Oh? It compiles fine for me. What doesn't compile exactly?

The GetTypeInformation() method is in TypeExtensions.cs, in project FakeItEasy.Tests.TestHelpers. It exists for historical reasons to resolve an ambiguity, but it has been removed in master.

@thomaslevesque
Copy link
Member

Oh? It compiles fine for me.

And more importantly, on AppVeyor

@thomaslevesque
Copy link
Member

There are a few warnings left in FakeTests.cs
https://ci.appveyor.com/project/FakeItEasy/fakeiteasy/builds/29084877#L79

thomaslevesque
thomaslevesque approved these changes Nov 24, 2019
View reviewed changes
Copy link
Member

@thomaslevesque thomaslevesque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks @asgerhallas!

@thomaslevesque thomaslevesque merged commit 07989d2 into FakeItEasy:support/5.x Nov 24, 2019
This was referenced Nov 25, 2019
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaslevesque thomaslevesque thomaslevesque approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asgerhallas @thomaslevesque