Record ReturnValue on CompletedFakeObjectCall

[thomaslevesque]

Fixes #1696

WIP because I want to try another approach Scratch that, my idea won't work...

[blairconrad]

Looks generally good, @thomaslevesque. I felt bad I hadn't told you to squash up earlier, but fortunately I had more comments and questions. In addition to the ones inline, I wonder if it isn't worthwhile testing a faked delegate as well? The implementation is slightly different. On the other hand, I do expect it to work, so I leave it to your discretion.

[blairconrad]

I meant to "request changes", at least for the unfixedup comment.

And I just thought of another thing ICompletedFakeObjectCall.ReturnValue has a slightly misleading comment, as I noted in the issue. Perhaps a good idea to fix up while you're here, if you'd be so kind, to indicate that it's the value that was returned, not the value set to be returned.

[thomaslevesque]

I wonder if it isn't worthwhile testing a faked delegate as well?

It is!

[thomaslevesque]

And I just thought of another thing ICompletedFakeObjectCall.ReturnValue has a slightly misleading comment, as I noted in the issue. Perhaps a good idea to fix up while you're here, if you'd be so kind, to indicate that it's the value that was returned, not the value set to be returned.

Will do

[blairconrad]

Thanks. Looking good. Squash it up!

[thomaslevesque]

Squash it up!

Done

[blairconrad]

Thanks, @thomaslevesque!

[thomaslevesque]

Thanks for the review!