Add ArgumentConstraintManagerExtensions.Contains overload that takes a StringComparison

[blairconrad]

Currently we force the comparison to use the current culture.

[thomaslevesque]

on platforms that support it

We could also emulate it on platforms that don't. Something like this maybe?

[thomaslevesque]

I think we have a bug in the existing Contains method... Or at least, an inconsistency between the platforms that have the overload with StringComparison and the ones that don't.

The code is like this:

#if FEATURE_STRING_CONTAINS_COMPARISONTYPE
            return manager.NullCheckedMatches(x => x.Contains(value, StringComparison.CurrentCulture), x => x.Write("string that contains ").WriteArgumentValue(value));
#else
            return manager.NullCheckedMatches(x => x.Contains(value), x => x.Write("string that contains ").WriteArgumentValue(value));
#endif

But the comparison used by the Contains overload without StringComparison is Ordinal, not CurrentCulture, so the behavior is not the same in the two versions.

This issue was introduced in https://github.com/FakeItEasy/FakeItEasy/pull/1666/files#diff-3f9aad371d3919486c2640596c21b7dcR80

[blairconrad]

Oh, interesting. And good point. Yeah, we should probably fix that. Better to revert to the ordinal behaviour, I think. And maybe this increases the priority of #1681?

[thomaslevesque]

Yes (in fact, this is #1681, I didn't open a new issue). I'm working on it

[thomaslevesque]

thomaslevesque changed the title Add ArgumentConstraintManagerExtensions.Contains overload that takes a StringComparison [DO NOT MERGE] Add ArgumentConstraintManagerExtensions.Contains overload that takes a StringComparison 5 hours ago

Oops, I confused the PR with the issue...

[afakebot]

This change has been released as part of FakeItEasy 6.0.0.

[thomaslevesque]

We should probably add overloads for StartsWith and EndsWith as well