Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor approval tests #1669

Merged
merged 3 commits into from Oct 21, 2019
Merged

Refactor approval tests #1669

merged 3 commits into from Oct 21, 2019

Conversation

thomaslevesque
Copy link
Member

As discussed in #1666

@thomaslevesque
Copy link
Member Author

By default ApprovalTests uses the name of the test to name the approved API file, but now all TFMs share the same name, so I had to customize the file names. I thought it was a good opportunity to reorganize those files. Let me know if you don't like it.

blairconrad
blairconrad previously approved these changes Oct 21, 2019
View reviewed changes
tests/FakeItEasy.Tests.Approval/ApiApproval.cs Outdated
[UseReporter(typeof(DiffReporter))]
[MethodImpl(MethodImplOptions.NoInlining)]
public void ApproveApi45()
public void ApproveFakeItEasyApi(string frameworkVersion)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I started reading, I was expecting to see a test parameterized by project name and frameworkVersion. This is good, though!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was expecting to see a test parameterized by project name and frameworkVersion

It could. Would you prefer it that way?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a new commit implementing that change

blairconrad
blairconrad approved these changes Oct 21, 2019
View reviewed changes
Copy link
Member

@blairconrad blairconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just making a comment about my guesses. I hadn't meant to push you into making the change—I was actually neutral on it. Until I saw the change, and I like the new way better, so I'm merging.
Thanks!

@blairconrad blairconrad merged commit 1c9c39a into FakeItEasy:master Oct 21, 2019
@blairconrad blairconrad added this to the vNext milestone Oct 21, 2019
@thomaslevesque thomaslevesque deleted the refactor-approval-tests branch October 21, 2019 10:28
@thomaslevesque
Copy link
Member Author

Thanks for the merge!

Next in line, #1662, which I just rebased. I'm afraid I have a few more coming after that...

@thomaslevesque
Copy link
Member Author

This change has been released as part of FakeItEasy 5.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blairconrad blairconrad blairconrad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thomaslevesque @blairconrad