Upgrade analyzers to .NET Standard 2.0 and test them on .NET Core #1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaslevesque
commented
Oct 18, 2019
| @@ -21,6 +21,8 @@ public override void Initialize(AnalysisContext context) | |||
| throw new ArgumentNullException(nameof(context)); | |||
| } | |||
|
|
|||
| context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.Analyze | GeneratedCodeAnalysisFlags.ReportDiagnostics); | |||
| context.EnableConcurrentExecution(); | |||
There was a problem hiding this comment.
Suggested by the "meta-analyzer"!
There was a problem hiding this comment.
Sorry, I mean the "analyzer for writing analyzers". https://github.com/dotnet/roslyn-analyzers#microsoftcodeanalysisanalyzers
| @@ -80,7 +80,7 @@ protected override void AnalyzeArgumentConstraintCore(string propertyFullName, S | |||
| if (nonNullableParameterType is object && | |||
| constraintType.IsValueType && | |||
| !constraintType.IsNullable() && | |||
| constraintType.Equals(nonNullableParameterType)) | |||
| SymbolEqualityComparer.Default.Equals(constraintType, nonNullableParameterType)) | |||
There was a problem hiding this comment.
Also the meta-analyzer
| @@ -51,27 +51,32 @@ public override Task RegisterCodeFixesAsync(CodeFixContext context) | |||
| context.RegisterCodeFix( | |||
| CodeAction.Create( | |||
| MakeConstraintNullableCodeFixTitle, | |||
| ct => MakeConstraintNullableAsync(context, diagnostic, ct)), | |||
| ct => MakeConstraintNullableAsync(context, diagnostic, ct), | |||
| equivalenceKey: "MakeConstraintNullable"), | |||
There was a problem hiding this comment.
Also the meta-analyzer
| diagnostic); | ||
| } | ||
|
|
||
| return CompletedTask; | ||
| } | ||
|
|
||
| public override FixAllProvider GetFixAllProvider() => WellKnownFixAllProviders.BatchFixer; |
There was a problem hiding this comment.
Do I need to say it again?
Merged
and test them on .NET Core 2.1 and 3.0
thomaslevesque
force-pushed
the
upgrade-analyzers
branch
from
c0fc4f4
to
e611973
Compare
blairconrad
approved these changes
Oct 21, 2019
There was a problem hiding this comment.
As far as I understand things (which I mostly don't), looks great! Thanks, @thomaslevesque.
|
This change has been released as part of FakeItEasy 5.4.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked the commits from my current work on #1662, I hope it didn't depend on anything I didn't include...