Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable package analysis #1661

Closed
blairconrad opened this issue Oct 16, 2019 · 3 comments
Closed

Re-enable package analysis #1661

blairconrad opened this issue Oct 16, 2019 · 3 comments

Comments

@blairconrad
Copy link
Member

blairconrad commented Oct 16, 2019

From #1627 (comment).

Quoth @thomaslevesque:

Note: I'm not seeing the NU5048 warning on FIE when using the latest SDK (3.0 RC1), not sure why. I tried on another project and the warning does appear.

Ah, that was because of this:

<NoPackageAnalysis>true</NoPackageAnalysis>

If we re-enable package analysis, there are some warnings that we should probably fix:

In FakeItEasy.Analyzer.CSharp:

  • warning NU5128: Some target frameworks declared in the dependencies group of the nuspec and the lib/ref folder do not have exact matches in the other location. Consult the list of actions below:
  • warning NU5128: - Add lib or ref assemblies for the netstandard1.1 target framework

In FakeItEasy.Analyzer.VisualBasic:

  • warning NU5128: Some target frameworks declared in the dependencies group of the nuspec and the lib/ref folder do not have exact matches in the other location. Consult the list of actions below:
  • warning NU5128: - Add lib or ref assemblies for the netstandard1.1 target framework
@thomaslevesque thomaslevesque changed the title Re-enable packge analysis Re-enable package analysis Oct 16, 2019
@thomaslevesque thomaslevesque self-assigned this Oct 24, 2019
@thomaslevesque thomaslevesque added this to the vNext milestone Oct 24, 2019
@thomaslevesque
Copy link
Member

Oops, I mentioned the issue in the PR, but without the "Fixes" keyword... Closing manually

@blairconrad
Copy link
Member Author

blairconrad commented Oct 24, 2019

Whoops. I didn't notice. Thanks.

@afakebot
Copy link

This change has been released as part of FakeItEasy 6.0.0-beta.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants