Add 'released as part of' notes to issues when releasing #1654
Conversation
|
I went for option 3—adding a note during pre-release and trying not to repeat it later. Parsing the numbers from the previous releases was easier than my initial idea of scraping the issues themselves. |
|
If you want, you can see where I tested on https://github.com/blairconrad/FakeItEasy/releases/tag/5.5.0 and https://github.com/blairconrad/FakeItEasy/releases/tag/5.5.0-beta.1 |
There was a problem hiding this comment.
Very nice, @blairconrad! Simple and to the point.
I just have one minor remark, and a suggestion.
tools/FakeItEasy.Deploy/Program.cs
Outdated
| } | ||
|
|
||
| string baseName = release.Name.Split('-')[0]; | ||
| return releases.Where(r => r.Prerelease && r.Name.StartsWith(baseName)); |
There was a problem hiding this comment.
I don't think this filter is sufficient. If the release is 5.1.1, it will match 5.1.10-beta.1.
Of course, under normal circumstances 5.1.10-xxx wouldn't exist... But I think it wouldn't hurt to include the dash in basename, i.e. match only issues starting with 5.1.1-.
There was a problem hiding this comment.
Yeah, I thought of this last night. And was too lazy. In addition to thinking that 5.1.10-xxx wouldn't exist, even if it did, it just means we're remove issues attributed to it from the thanking mechanism for 5.1.1, which... is fine?
But I'm happy to change.
tools/FakeItEasy.Deploy/Program.cs
Outdated
| @@ -63,9 +64,29 @@ public static async Task Main(string[] args) | |||
| await UploadPackageToNuGetAsync(file, nugetServerUrl, nugetApiKey); | |||
| } | |||
|
|
|||
| var issueNumbersInCurrentRelease = ReleaseHelpers.GetIssueNumbersReferencedFromReleases(new[] { release }); | |||
There was a problem hiding this comment.
Maybe consider using static ReleaseHelpers? If you prefer to keep it explicit, it's fine by me, but I just wanted to mention the possibility.
|
Thanks for the comments, @thomaslevesque. I pushed fixups. I figured I'd wait for the rebase until I'm squashing anyhow… |
| string baseName = BaseName(release); | ||
| return releases.Where(r => r.Prerelease && BaseName(r) == baseName); | ||
|
|
||
| string BaseName(Release release) => release.Name.Split('-')[0]; |
blairconrad
force-pushed
the
auto-issue
branch
from
ac83b93
to
41e2f8c
Compare
|
Thanks, @thomaslevesque. Squashed. |
Fixes #1652.