Switch to SourceLink instead of PdbGit

[thomaslevesque]

At some point, SourceLink worked only with portable PDBs, but ILMerge doesn't like those. But now this limitation has been removed, and I think there would be benefits to using SourceLink instead of PdbGit:

• SourceLink has joined the .NET Foundation and is now the officially supported way to enable source stepping
• It's actively maintained, whereas PdbGit hasn't released a new version in almost 2 years
• It integrates better with the build process (just reference the package and you're done, no need to do it explicitly in the build script)

[thomaslevesque]

It integrates better with the build process (just reference the package and you're done, no need to do it explicitly in the build script)

We probably need to be careful about how it interacts with ILMerge, though

[thomaslevesque]

Oh, and it also takes care of including the PDB in the NuGet package; no more hack 😉

[thomaslevesque]

@blairconrad any objection? I can start working on it today.

[thomaslevesque]

OK, it's not going to be that simple... It works fine for netstandard1.6, but not for net40/net45, because of ILMerge. SourceLink works by generating a file that is passed as an argument to csc.exe with the -sourcelink option. It doesn't rewrite the PDB like PdbGit does, it just includes the necessary information in the PDB from the start. The problem is that ILMerge doesn't preserve that information, and until it does, we're stuck...

[blairconrad]

Bummer!

[thomaslevesque]

I still want to do this, but for now we're stuck... I'll put it on-hold for now (maybe we should have a "blocked" label)

[thomaslevesque]

@blairconrad I assume we can remove the discussion tag, unless you're not convinced by SourceLink?
FYI, I tried it, after removing ILMerge, and it works fine!

[afakebot]

This change has been released as part of FakeItEasy 6.0.0-beta.1.