Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support wavy underlines #1131

Closed
shoaniki opened this issue Jul 18, 2022 · 1 comment
Closed

Support wavy underlines #1131

shoaniki opened this issue Jul 18, 2022 · 1 comment

Comments

@shoaniki
Copy link
Contributor

Desired Feature

When a user is editing text in a StyledTextArea, I wish to indicate typos and other kinds of error using the standard visual representation of a wavy underline.

Current Workarounds

So far as I can determine, underlines currently can only be solid or dotted straight lines. Dotted underlines are not unheard-of for marking typos, and that's what the RichTextFX spellchecker demo currently uses, but it is not the most familiar representation and may confuse users, particularly if colors other than red are to be used for different types of annotation.

Implementation Costs

I have a basic implementation which I am submitting for discussion as a PR. It involves creating a couple of extra CSS properties and then adding a branch to the code that creates underline shapes.

Jugen pushed a commit that referenced this issue Jul 21, 2022
Support wavy underlines, and allow the distance between text and underline to be configured.
@Jugen
Copy link
Collaborator

Jugen commented Jul 21, 2022

Thanks a lot for the PR :-)

@Jugen Jugen closed this as completed Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants