Avoid agent clone

[emmansun]

#124

[FGRibreau]

Would it be possible to remplace "_.cloneDeep" into our own "clone" functions that would have the responsability to NOT clone the agent? It seems to me it would be cleaner, don't you think?

[emmansun]

What's the risk if we do not clone the options?

[FGRibreau]

"Never" use for(let a in obj), see:

a = {a:true};
a.__proto__.b = 3;
for (let key in a) {
console.log(key);}

See: http://bonsaiden.github.io/JavaScript-Garden/#object.hasownproperty

[FGRibreau]

Near completion, a test for this use-case is missing and then I will merge it 👌

[FGRibreau]

Hum the test cannot pass with this:

t.deepEqual(cloneable, this.options.cloneable);
t.notEqual(cloneable, this.options.cloneable);

Also, no need to add a strategy, the idea is too keep the test as small as possible with only whats required to run it :)

[emmansun]

added clone.test.js

[FGRibreau]

Need test update

[FGRibreau]

_cloneOptions(this.options)

output is available as the retryStrategy input. Instead of relying on a hack like rewire why not create a test, that specify :

• an agent as option
• its own retryStrategy, that we will use to check that agent was not duplicated

it should be a lot simpler, won't require rewire, have a simpler setup phase and only 2 assertions will be required (one for the agent the other for the other field that was cloned)

[FGRibreau]

Thanks @emmansun ! Released in v4.1.2!

[emmansun]

Thank @FGRibreau for your patience and help!