Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional dependencies needed for Python < 3.8 #2

Closed
jmroot opened this issue Oct 26, 2021 · 6 comments
Closed

Additional dependencies needed for Python < 3.8 #2

jmroot opened this issue Oct 26, 2021 · 6 comments

Comments

@jmroot
Copy link

jmroot commented Oct 26, 2021

I don't know if supporting these versions is even something you want to do, but I thought it should be noted somewhere that if you want to bootstrap on Python 3.7 or 3.6, you also need importlib-metadata and its dependencies.

@FFY00
Copy link
Owner

FFY00 commented Oct 26, 2021

Which package pulls it? pypa/build does not actually need it if you pass --skip-dependency-check, exactly to support bootstrapping without it.

https://pypa-build.readthedocs.io/en/stable/installation.html#bootstrapping

@jmroot
Copy link
Author

jmroot commented Oct 26, 2021

Which package pulls it?

pep517 https://github.com/pypa/pep517/blob/main/pyproject.toml#L14

@FFY00
Copy link
Owner

FFY00 commented Oct 26, 2021

That is only used in pep517.meta, which is not needed by pypa/build anyway. Are you seeing any runtime failure?

https://github.com/pypa/pep517/search?q=importlib_metadata

@jmroot
Copy link
Author

jmroot commented Oct 26, 2021

Hm, I thought I had, but now that I try again from scratch with 3.6, I don't. Never mind, sorry.

@jmroot jmroot closed this as completed Oct 26, 2021
@FFY00
Copy link
Owner

FFY00 commented Oct 26, 2021

No worries, I should still document this 😊

@jmroot
Copy link
Author

jmroot commented Nov 2, 2021

Tracked it down, the issue was actually in build. PR submitted: pypa/build#401

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants