Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WaitReady if directory does not exist #84

Merged
merged 4 commits into from Nov 24, 2022
Merged

Fix WaitReady if directory does not exist #84

merged 4 commits into from Nov 24, 2022

Conversation

ondrej-fabry
Copy link
Member

@ondrej-fabry ondrej-fabry commented Nov 8, 2022

This PR contains alternative to #83 which is a fix for issue described in #81.

@ondrej-fabry ondrej-fabry marked this pull request as draft November 9, 2022 13:04
@ondrej-fabry ondrej-fabry marked this pull request as ready for review November 24, 2022 08:13
@ondrej-fabry ondrej-fabry added this to the v0.7.0 milestone Nov 24, 2022
@ondrej-fabry ondrej-fabry linked an issue Nov 24, 2022 that may be closed by this pull request
@ondrej-fabry ondrej-fabry requested a review from a team November 24, 2022 08:14
@sknat sknat merged commit d8a7de3 into master Nov 24, 2022
@sknat sknat deleted the fix-wait-reay branch November 24, 2022 14:39
@mhalaj1
Copy link
Contributor

mhalaj1 commented Nov 29, 2022

The function WaitReady should start with checking for socket existence. If the socket already exists, we do not need to watch the directories.
Otherwise, this looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Function WaitReady does not wait if socket dir does not exist
3 participants