Fix endless loop in Reset #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes a bug where the drain channel loop would run forever. This happens when reqChan gets closed which makes the case with closed channel be selected instantly. The fix is to set reqChan to nil which practically ignores that case in the select. Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
sknat
reviewed
Oct 3, 2022
- make the genericpool.Pool's Put method synchronous and invoke it asynchronously - add debug message when draining occurs in Reset - set replyChan to nil if closed (currently it never gets closed, but just to be sure) Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
sknat
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a bug where the drain channel loop would run forever.
This happens when reqChan gets closed which makes the case with closed channel be selected instantly.
The fix is to set reqChan to nil which practically ignores that case in the select.