Fix panic on the pool put/get operations #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous commit fd89a9 added extra & on 'put' to the pool.
This was the reason of panic on 'get' method:
panic: interface conversion: interface {} is **[]uint8, not *[]uint8
Signed-off-by: Rinat Baygildin <bayrinat@yandex-team.ru>
Change-Id: Icce0ee55ee4439c4d9842f4c1b82878bcc309331
One millisecond timeout is not enough for ci, increase it to prevent flaps. Signed-off-by: Rinat Baygildin <bayrinat@yandex-team.ru> Change-Id: I1534b8ad4ef9e5b76b4fb00213ad377c20083377 Signed-off-by: Rinat Baygildin <bayrinat@yandex-team.ru>
|
@ondrej-fabry hello, master is broken, let's fix it. Review and merge plz. |
ondrej-fabry
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix panic of interface conversion
The previous commit fd89a9 added extra & on 'put' to the pool.
This was the reason of panic on 'get' method:
panic: interface conversion: interface {} is **[]uint8, not *[]uint8
Increase reply timeout on tests
One millisecond timeout is not enough for ci, increase it to prevent flaps.