Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent data race on msgMapByPath map #50

Merged
merged 1 commit into from Sep 28, 2022
Merged

Prevent data race on msgMapByPath map #50

merged 1 commit into from Sep 28, 2022

Conversation

bayrinat
Copy link
Contributor

@bayrinat bayrinat commented Sep 27, 2022 •
edited by ondrej-fabry 

==================                                                                                                                                                           
 WARNING: DATA RACE                                                                                                                                                           
 Read at 0x00c00041f290 by goroutine 17:                                                                                                                                      
   runtime.mapaccess2_faststr()                                                                                                                                               
       /usr/local/go/src/runtime/map_faststr.go:108 +0x0                                                                                                                      
   race-project/vendor/git.fd.io/govpp.git/core.(*Connection).GetMessageID()                                                                              
       race-project/vendor/git.fd.io/govpp.git/core/connection.go:420 +0x15c                                                                              
   race-project/vendor/git.fd.io/govpp.git/core.(*Connection).processRequest()                                                                            
       race-project/vendor/git.fd.io/govpp.git/core/request_handler.go:73 +0x48e                                                                          
   race-project/vendor/git.fd.io/govpp.git/core.(*Connection).watchRequests()                                                                             
       race-project/vendor/git.fd.io/govpp.git/core/request_handler.go:47 +0x9e                                                                           
   race-project/vendor/git.fd.io/govpp.git/core.(*Connection).newAPIChannel.func1()                                                                       
       race-project/vendor/git.fd.io/govpp.git/core/connection.go:261 +0x47                                                                               
 Previous write at 0x00c00041f290 by goroutine 75:                                                                                                                            
   runtime.mapassign_faststr()                                                                                                                                                
       /usr/local/go/src/runtime/map_faststr.go:203 +0x0                                                                                                                      
   race-project/vendor/git.fd.io/govpp.git/core.(*Connection).GetMessageID()                                                                              
       race-project/vendor/git.fd.io/govpp.git/core/connection.go:421 +0x2af                                                                              
   race-project/vendor/git.fd.io/govpp.git/core.(*Channel).CheckCompatiblity()                                                                            
       race-project/vendor/git.fd.io/govpp.git/core/channel.go:176 +0x187                                                                                 
   race-project/cloudgate/vpp/govpp.(*Channel).CheckCompatibility()                                                                                       
       race-project/cloudgate/vpp/govpp/channel.go:32 +0x9b

@bayrinat
Prevent data race on msgMapByPath map
ef71a3a 
Signed-off-by: Rinat Baygildin <bayrinat@yandex-team.ru>
Change-Id: If0839f5ec093e67f5e1352954a13c89874fa9350
@bayrinat
Copy link
Contributor Author

bayrinat commented Sep 28, 2022 •
edited

@ondrej-fabry could you review it, plz?

@bayrinat
Copy link
Contributor Author

@ondrej-fabry and merge plz, if it's ok :)

@ondrej-fabry ondrej-fabry merged commit e7c28a0 into FDio:master Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ondrej-fabry ondrej-fabry ondrej-fabry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bayrinat @ondrej-fabry