Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run more steps in CI #49

Closed
4 tasks done
ondrej-fabry opened this issue Sep 23, 2022 · 2 comments
Closed
4 tasks done

Run more steps in CI #49

ondrej-fabry opened this issue Sep 23, 2022 · 2 comments
Assignees
Labels
ci Continous Integration
Milestone

Comments

@ondrej-fabry
Copy link
Member

ondrej-fabry commented Sep 23, 2022

To improve the quality of the code that is merged to master, the CI pipeline should perform more tests or checks for common things developers forget to update.

@ondrej-fabry ondrej-fabry added the ci Continous Integration label Sep 23, 2022
@ondrej-fabry ondrej-fabry added this to the v0.7.0 milestone Sep 23, 2022
@ondrej-fabry ondrej-fabry self-assigned this Sep 23, 2022
@ondrej-fabry ondrej-fabry changed the title Run checks in CI Run more checks in CI Oct 5, 2022
@ondrej-fabry ondrej-fabry linked a pull request Oct 6, 2022 that will close this issue
@ondrej-fabry ondrej-fabry reopened this Oct 17, 2022
@ondrej-fabry ondrej-fabry changed the title Run more checks in CI Run more steps in CI Oct 17, 2022
@ondrej-fabry ondrej-fabry removed a link to a pull request Oct 17, 2022
@dwallacelf
Copy link
Collaborator

Do we need a docs verification task?

I was able to review PR#70 by going to the 'Files Changed' tab and selecting '...'/'View file' for docs/troubleshooting.md which showed that the markdown rendered correctly.

However, if the syntax was incorrect, does anything in the CI run *.md files through the github renderer and mark it as not mergeable?

As an optimization, it would be good to skip the build verification tasks for docs only PR's, but may not be worth implementing if it make the CI too complex.

@ondrej-fabry
Copy link
Member Author

All tasks complete as part of release v0.7.0. For the rest separate issues were created for tracking them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continous Integration
Projects
Archived in project
Development

No branches or pull requests

2 participants