fix: Fix format of package comment #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new go formatter code removes empty comment lines at beginning/end of comment section. This PR removes extra added newline after list of package contents and adds dash before each object. This avoids tooling to match the padding as indent. Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
…age comments The version of VPP used for generating the binapi code is now fixed in Makefile to allow reproducibility. Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
ondrej-fabry
changed the title
edwarnicke
reviewed
Sep 20, 2022
sknat
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new go formatter code removes empty comment lines at beginning/end of comment section. This PR removes extra added newline after list of package contents and adds dash before each object. This avoids tooling to match the padding as indent.
Changes