linter: fixes for staticcheck #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems pointless to add special comments to the generated files. The tool should ignore the generated files entirely. |
edwarnicke
reviewed
Aug 23, 2022
sknat
force-pushed
the
improve/linter
branch
from
34379e1
to
bce5cd5
Compare
|
Removed the changes in the generated code for now & updated the patch |
As golint is now deprecated, this patch proposes to switch to staticcheck [0] as an alternative, in addition to `go vet`. This patch contains fixes addressing the linter's reported issues, with two added exceptions : - The MemoryStats deprectated fields are still for us to update - In `gen_encoding.go` we need to add an extra comment to account for the unused variable. This is probably worth addressing in another patch to not generate a variable we don't use. [0] https://staticcheck.io/ Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com> Change-Id: I0562f290fb908bc610c44d675e21e466d0badc27
sknat
force-pushed
the
improve/linter
branch
from
bce5cd5
to
41120f7
Compare
ondrej-fabry
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As golint is now deprecated, this patch proposes to
switch to staticcheck [0] as an alternative, in addition
to
go vet.This patch contains fixes addressing the linter's reported
issues, with two added exceptions :
gen_encoding.gowe need to add an extra commentto account for the unused variable. This is probably worth
addressing in another patch to not generate a variable we don't use.
[0] https://staticcheck.io/
Signed-off-by: Nathan Skrzypczak nathan.skrzypczak@gmail.com
Change-Id: I0562f290fb908bc610c44d675e21e466d0badc27