[HOLD for payment 2022-02-08] Web - JS Console error appears when clicking user name

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Start a chat with a user.
2. Click on your avatar in the chat and verify that no Message button is visible.
3. Now click on another user's avatar and verify that the Message button is visible and clicking it opens the chat with that user.
4. Check the JS console

Expected Result:

Verify that no errors appear in the JS console

Actual Result:

Errors appeared in the JS console

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web

Version Number: v1.1.30-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @cead22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

Triggered auto assignment to @puneetlath (Demolition), see https://stackoverflow.com/c/expensify/questions/8099 for more details.

[cead22]

Oh hmmm I reproduced and added the Demolition label but on second thought, I think it's possible that external contributor can fix this. @puneetlath Do you want to take a stab at this or should I label External? The error message says

Please instead use `remove()` on the subscription returned by `EventEmitter.addListener`.

But I honestly don't know if it's that easy

[sig5]

Proposal (If labelled external )

There is an upstream change, where in react-native@0.65.0 they deprecated the old api in favour of a more terse name, so removeListener() becomes remove().

This error is shown because we are using an outdated version of react-native-modal.

Related issue: The issue has been solved in version 13.0.0 of the dependency.
So merely upgrading this dependency to 13.0.0 resolves the issue.
Link to the release with breaking changes: https://github.com/react-native-modal/react-native-modal/releases/tag/v13.0.0

Since we are already on react-native 0.66.4, there should be no issues with the upgrade.

[puneetlath]

@cead22 let's go external.

[MelvinBot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

[puneetlath]

Upwork job: https://www.upwork.com/jobs/~014d0c018e3c86ed2f

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

[MelvinBot]

Current assignee @puneetlath is eligible for the Exported assigner, not assigning anyone new.

[rushatgabhane]

🎀👀🎀 C+ reviewed

Coming from #6914

We should follow-up with an issue to upgrade react-native-modal because it's throwing errors due to the deprecated removeEventListener function. This has been fixed in their latest version.

I like @sig5's proposal. After reading the changelog, I don't think it'll break anything and should fix this issue.

cc: @puneetlath

[puneetlath]

Agreed, seems like a straightforward solution.

[MelvinBot]

📣 @sig5 You have been assigned to this job by @puneetlath!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[puneetlath]

@sig5 how is this going?

[sig5]

Hi Puneet, this has been merged here to staging. I can't reproduce the issue on staging. So I think it works as expected.
#7333 (comment)

[puneetlath]

Lol whoops. Totally missed that. In spite of me being the one who merged the PR 🤦🏾. Thanks!

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[botify]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.33-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Upgraded react-native-modal to v13.0.0 #7333

If no regressions arise, payment will be issued on 2022-02-08. 🎊

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[puneetlath]

Paid!