Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracking] Deprecate jCenter in build.gradle #7190

Closed
Jag96 opened this issue Jan 13, 2022 · 3 comments
Closed

[Tracking] Deprecate jCenter in build.gradle #7190

Jag96 opened this issue Jan 13, 2022 · 3 comments
Assignees
Labels
Engineering Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@Jag96
Copy link
Contributor

Jag96 commented Jan 13, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Coming from this discussion, jcenter will no longer be updated. As a result, mavenCentral will be used instead for all react-native-community packages. More conversation in this internal thread where we discussed migrating over to mavenCentral.

Creating this tracking issue for discussion and updates related to updating 3rd party packages to use mavenCentral.

cc @Expensify/mobile-deployers

@Jag96 Jag96 added Engineering Weekly KSv2 Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff labels Jan 13, 2022
@Jag96 Jag96 self-assigned this Jan 13, 2022
@roryabraham
Copy link
Contributor

Two known packages that have ditched jcenter but not yet included that change in a release:

We'll want to upgrade those by either pointing our dependency directly at a git commit or by waiting for them to release new versions of their packages. There might be other dependencies that need upgrading as well.

@Julesssss
Copy link
Contributor

Julesssss commented Jan 13, 2022

Here's a PR I opened previously for removing NewDot Onfido BinTray dependency. Please feel free to review! I also resolved the OldDot BinTray dependency a few weeks ago.

We'll want to upgrade those by either pointing our dependency directly at a git commit or by waiting for them to release new versions of their packages.

I don't think we should do this. BinTray is the troublesome repo, because it has completely shut down and we should replace these dependencies (we have done this already ✅ ). JCenter will continue to host indefinitely, so we simply need to migrate away as and when we bump lib versions. As @roryabraham has already added the mavenCentral repo to NewDot, I suggest that we do nothing -- in the unlikely event that a library is not hosted on mavenCentral, it will almost certainly be mentioned in the release notes for that library and can be dealt with manually then.

@Julesssss
Copy link
Contributor

Julesssss commented Jan 13, 2022

I should have created this issue when raising the PRs, so thanks for doing that @Jag96! I suggest we do the following before marking this as resolved:

@botify botify closed this as completed Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants