New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it again browser compatible #268
Make it again browser compatible #268
Conversation
@joeybaker could you please review this? |
@ajinkyarajput looks like standard is failing. Would you mind seeing if an upgrade fixes things? |
@joeybaker , upgrading standard failing existing code. Defined URL as global variable to resolved issue. |
@joeybaker As previous version has vulnerability, and current version not working for browser, could you please review and release it? |
@ajinkyarajput thanks for fixing standard. I'm cool with that config change :) Could you do me a favor and update https://github.com/EventSource/eventsource/blob/master/HISTORY.md for version 2.0.1? I'll merge this after! |
@joeybaker Updated history.md. Please feel free to update package.json and package-lock.json. Thank you for your prompt action. It’s greatly appreciated. |
@rexxars would you mind doing a release? |
@rexxars Do you think you could publish on npm? |
Published as v2.0.1 |
Thank you @rexxars |
After release 2.0.0, the issue mentioned startup. Reason is nodejs built in package imports URL as variable but not in most of the url polyfill.
Solution: As URL class available in both nodejs and browser globally, we don't have to import it from url package.