Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it again browser compatible #268

Merged
merged 3 commits into from Apr 22, 2022

Conversation

ajinkyarajput
Copy link
Contributor

@ajinkyarajput ajinkyarajput commented Apr 21, 2022

After release 2.0.0, the issue mentioned startup. Reason is nodejs built in package imports URL as variable but not in most of the url polyfill.

Solution: As URL class available in both nodejs and browser globally, we don't have to import it from url package.

@ajinkyarajput
Copy link
Contributor Author

@joeybaker could you please review this?

@joeybaker
Copy link
Contributor

@ajinkyarajput looks like standard is failing. Would you mind seeing if an upgrade fixes things?

@ajinkyarajput
Copy link
Contributor Author

@joeybaker , upgrading standard failing existing code. Defined URL as global variable to resolved issue.

@ajinkyarajput
Copy link
Contributor Author

ajinkyarajput commented Apr 22, 2022

@joeybaker As previous version has vulnerability, and current version not working for browser, could you please review and release it?

@joeybaker
Copy link
Contributor

@ajinkyarajput thanks for fixing standard. I'm cool with that config change :)

Could you do me a favor and update https://github.com/EventSource/eventsource/blob/master/HISTORY.md for version 2.0.1?

I'll merge this after!

@ajinkyarajput
Copy link
Contributor Author

@joeybaker Updated history.md. Please feel free to update package.json and package-lock.json. Thank you for your prompt action. It’s greatly appreciated.

@joeybaker joeybaker merged commit 9321d5c into EventSource:master Apr 22, 2022
@joeybaker
Copy link
Contributor

@rexxars would you mind doing a release?

@ajinkyarajput
Copy link
Contributor Author

@rexxars Do you think you could publish on npm?

@rexxars
Copy link
Member

rexxars commented Apr 25, 2022

Published as v2.0.1

@ajinkyarajput
Copy link
Contributor Author

Thank you @rexxars

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants