Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's with the monkeypatching of Terminal.scrollToBottom? #1578

Closed
Tyriar opened this issue Oct 3, 2019 · 4 comments
Closed

What's with the monkeypatching of Terminal.scrollToBottom? #1578

Tyriar opened this issue Oct 3, 2019 · 4 comments

Comments

@Tyriar
Copy link
Contributor

Tyriar commented Oct 3, 2019

I'm curious why you are doing this:

https://github.com/Eugeny/terminus/blob/86e1abd44f272e76aa0194af6daa305b4ad68363/terminus-terminal/src/frontends/xtermFrontend.ts#L84-L85

@Eugeny
Copy link
Owner

Eugeny commented Oct 4, 2019

This is to prevent xterm from unconditionally scrolling to the bottom on user input (see xtermjs/xterm.js#1824)

@Tyriar
Copy link
Contributor Author

Tyriar commented Oct 4, 2019

@Eugeny I still don't really understand the problem, if you're in tmux you're in the alt buffer which means you have no scrollback or scroll bar and scrollToBottom should essentially do nothing?

@Eugeny
Copy link
Owner

Eugeny commented Oct 4, 2019

@Tyriar it's really not just related to #543 - some people want to avoid losing the scroll position by accidentally hitting a key

@Tyriar
Copy link
Contributor Author

Tyriar commented Oct 4, 2019

Makes sense 👍 opened xtermjs/xterm.js#1824 up to PRs

@Tyriar Tyriar closed this as completed Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants