Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a floating info icon at the bottom right of the app when Cover page or Introduction window option is on #608

Open
azizaparveen opened this issue Apr 16, 2024 · 8 comments
Assignees
Labels
2-ENH New feature or request Manager component Manager 4.x a.k.a Crowdsource Manager
Milestone

Comments

@azizaparveen
Copy link
Collaborator

Describe requirements

In this release, Instant App team added Cover page or introduction window parameter in About -> App Introduction tab, when this option is on but the cover page or Introduction window is closed, we would like to show an info icon so users can access it from this icon button
image
image

Alternatives

No response

Other Relevant Info

No response

Impact

No response

@azizaparveen azizaparveen added 2-ENH New feature or request Manager 4.x a.k.a Crowdsource Manager Manager component labels Apr 16, 2024
@azizaparveen azizaparveen added this to the 2024.R02 milestone Apr 16, 2024
@sumitzarkar
Copy link
Collaborator

sumitzarkar commented Apr 17, 2024

We have some questions on this:

@azizaparveen

  • Do we need to show the info icon only when Introdution window is selected in the config?

@jmhauck

  • Is this Introdution controlled from Instant app or will it be created in Manager
  • If it is from instant app, how can we open it from the floating info button in the app.
  • Do we have any mechanism in place for this, Or this needs to be done in the instant app?

@jmhauck
Copy link
Collaborator

jmhauck commented Apr 17, 2024

@sumitzarkar we should emit an event when that button is clicked. They should be able to listen for the event and trigger the opening of the cover page.

@prachichawande-ct
Copy link
Collaborator

@azizaparveen

Dev Checklist

Items ​ Is required​ Status Comments​
Required NLS changes?​ No
Required Backward compatibility​ No
Required 508​ Yes
Need Sanitize?​ No

Impact Analysis Report

Impacted Areas Comments
Have Configuration changes?​ No
Have Runtime changes?​ Yes
Impact on RTL Yes
Impact at runtime The Floating info icon should be displayed at the bottom right of the app
The icon should be displayed according to the theme (light/dark)
On click of info icon should emit an event

@azizaparveen
Copy link
Collaborator Author

@sumitzarkar the floating icon is showing even if the Cover page or introduction window option is off , both in config preview and runtime
image

@sumitzarkar
Copy link
Collaborator

the floating icon is showing even if the Cover page or introduction window option is off , both in config preview and runtime

@jmhauck

Please add pass the boolean value to the manager component, we will add the condition to show the info button when this boolean value is true

@azizaparveen
Copy link
Collaborator Author

@sumitzarkar. clicking on the floating icon is not opening when the floating icon is clicked here is a test app https://sg-em-devext.mapsdevext.arcgis.com/apps/instant/manager/index.html?appid=d30ffa4fcdde411f8ced045a26d72030
I have the Introduction window parameter on,
To repro:

  1. after launching the app, click Enter, the window will go away ,
  2. Then click on the floating icon and notice that it does not open it back

image

cc @sarahmcdonald7

@azizaparveen
Copy link
Collaborator Author

azizaparveen commented May 22, 2024

@sumitzarkar we need to fix these few things

  1. Remove i button from header, it should only be on the bottom right corner when the option is enabled.
  2. If it is Introduction window, the i icon will show but if it is a cover page, cover page icon will show. sorry I didn't realize and communicate this before
    image

@sumitzarkar
Copy link
Collaborator

sumitzarkar commented May 24, 2024

@azizaparveen @jmhauck

Remove i button from header, it should only be on the bottom right corner when the option is enabled.

  • This needs to be implemented in Instant App - @jmhauck - please confrim

If it is Introduction window, the i icon will show but if it is a cover page, cover page icon will show

  • We have added the code to show the coverPage/InformationWindo icon
  • UI For Information Window
    image
  • Event or information window clicked will be showIntroductionWindow
  • UI For CoverPage
    image
  • Event or cover page clicked will be showCoverPage

We have implemented this and will deliver it in the next code drop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2-ENH New feature or request Manager component Manager 4.x a.k.a Crowdsource Manager
Projects
None yet
Development

No branches or pull requests

4 participants