Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suport for sort capability to sort reports #606

Open
skrishn opened this issue Apr 11, 2024 · 4 comments
Open

Suport for sort capability to sort reports #606

skrishn opened this issue Apr 11, 2024 · 4 comments
Assignees
Labels
Reporter 4.x Crowdsource Reporter (new)

Comments

@skrishn
Copy link
Collaborator

skrishn commented Apr 11, 2024

#590 (comment)

sort options : newest, oldest, highest voted, lowest voted

@skrishn skrishn added the Reporter 4.x Crowdsource Reporter (new) label Apr 11, 2024
@skrishn
Copy link
Collaborator Author

skrishn commented Apr 11, 2024

#590 (comment)

As discussed on the call, we can show the menu for the sort options.
Below is the updated UI for the sort

image

image

@skrishn
Copy link
Collaborator Author

skrishn commented Apr 11, 2024

@sumitzarkar @prachichawande-ct

Looks good. How are we handling the scenarios?

  1. When like is not enabled in the layer - I'm expecting we don't show the options (Highest and lowest vote) in that case
  2. When like was once enabled but now disabled - In this case, there would be values in the like field, but it would be confusing to sort the reports based on the values. So, we wouldn't display it.

@sumitzarkar
Copy link
Collaborator

@skrishn

  1. When like is not enabled in the layer - I'm expecting we don't show the options (Highest and lowest vote) in that case
  2. When like was once enabled but now disabled - In this case, there would be values in the like field, but it would be confusing to sort the reports based on the values. So, we wouldn't display it.

In both the scenarios we will not show the Highest voted and Lowest voted options for sorting

@prachichawande-ct
Copy link
Collaborator

@skrishn

Dev Checklist

Items ​ Is required​ Status Comments​
Required NLS changes?​ Yes
Required Backward compatibility​ No
Required 508​ Yes
Need Sanitize?​ No

Impact Analysis Report

Impacted Areas Comments
Have Configuration changes?​ No
Have Runtime changes?​ Yes
Impact on RTL Yes
Impact on runtime feature list The feature list should be sorted depending on the selected sorting options
  • On the Newest option click, the feature list should be sorted in the descending order of the selected layer's OBJECTID field
  • On the Oldest option click, the feature list should be sorted in the ascending order of the selected layer's OBJECTID field
  • On the Highest voted option click, the feature list should be sorted in the descending order of the configured like field
  • On the Lowest voted option click, the feature list should be sorted in the ascending order of the configured like field
The Highest and lowest voted sorting option should be hidden in the cases:
  • If the like field is not enabled and configured in the selected layer's configuration
  • If the like field was once enabled but now disabled
On the sort option click, the selected option should be active in the feature list panel
By default, Newest option should be selected and sorting should be done accordingly
If the same layer is selected from the layer list then the previous applied sort should be reset
Desktop Mode UI Mobile mode UI
image image

sumitzarkar added a commit that referenced this issue May 17, 2024
-  Updated code to support sorting of the features list - #606
- Updated features list to reuse for comment list - #592
sumitzarkar added a commit that referenced this issue May 17, 2024
- Added support for sorting features list
- Added Support for comment functionality
- #592
- #606
- #630
sumitzarkar added a commit that referenced this issue May 20, 2024
## Implemented
- Code review comments from previous pull request
- Fixed minor testing issues
- #592
- #606
- #630
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reporter 4.x Crowdsource Reporter (new)
Projects
None yet
Development

No branches or pull requests

3 participants