Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getContentFromHub should overwrite most properties with their value from the item. #521

Open
mjuniper opened this issue May 5, 2021 · 0 comments
Labels
chore Content Related to the esri/hub-content package

Comments

@mjuniper
Copy link
Member

mjuniper commented May 5, 2021

When I initially did #499, @tomwayson said:

I think we should add more overrides here.
...
Honestly, I think it'd be better to use a block list based on known oddities (name, extent, etc) than an allow list.

I did not do follow his advice at the time because it seemed less risky to scope it to things I knew I needed. And also because mergeObjects takes a whitelist. But I have come around to his way of thinking. We should switch to using a blacklist and overwrite most properties with their values from the item.

@mjuniper mjuniper added chore Content Related to the esri/hub-content package labels May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Content Related to the esri/hub-content package
Projects
None yet
Development

No branches or pull requests

1 participant