Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamicMapLayer and ImageMapLayer with json/image + token/proxy support #1184

Closed
16 tasks done
jwasilgeo opened this issue Jan 31, 2020 · 2 comments
Closed
16 tasks done
Labels

Comments

@jwasilgeo
Copy link
Contributor

jwasilgeo commented Jan 31, 2020

As of v2.3.3, DynamicMapLayer.js and ImageMapLayer.js (both of which extend from RasterLayer) do not fully support certain options combinations of f: 'json' or f: 'image' coupled with a token or a proxy.

DynamicMapLayer

token support

  • f: 'json' and token in source code
  • f: 'json' and token has unit test
  • f: 'image' and token in source code
  • f: 'image' and token has unit test

proxy support

  • f: 'json' and proxy in source code
  • f: 'json' and proxy has unit test
  • f: 'image' and proxy in source code
    • (would need to remove the entire f override in the initialize method)
  • f: 'image' and proxy has unit test

ImageMapLayer

token support

  • f: 'json' and token in source code
  • f: 'json' and token has unit test
  • f: 'image' and token in source code
  • f: 'image' and token has unit test

proxy support

  • f: 'json' and proxy in source code
  • f: 'json' and proxy has unit test
  • f: 'image' and proxy in source code
  • f: 'image' and proxy has unit test

Additional info and breadcrumbs

issue #1180
pr #1181
pr #1182

@gavinr
Copy link
Contributor

gavinr commented Jul 27, 2020

@jwasilgeo I think we're good now after all those PRs. Could you please take a look and close if you think it's resolved.

@jwasilgeo
Copy link
Contributor Author

I've taken another look and I agree. Thanks for all that--huge help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants