Update DynamicMapLayer.js to work with token/proxy #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for DynamicLayer and token/proxy with imageData response
|
Thanks for the contribution Chris! Is this related to a particular logged issue? |
|
It's related to Issue #1153 |
|
@crb04c it looks like there are errors in the unit tests - can you check that to see if there's an issue or do the tests need to be updated? Thanks! |
|
@gavinr I can take a look at the tests. My initial reaction was it was unrelated due to the location and content of the tests but I'll see if I can fix it |
|
its very likely that if @gavinr restarts the test suite, it'll pass ✅. |
|
Thanks @jgravois. Will try that now. |
jgravois
pushed a commit
to jgravois/esri-leaflet
that referenced
this pull request
Apr 23, 2022
Update DynamicMapLayer.js to work with token/proxy
jgravois
pushed a commit
to jgravois/esri-leaflet
that referenced
this pull request
Apr 23, 2022
Update DynamicMapLayer.js to work with token/proxy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for DynamicLayer and token/proxy with imageData response