Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember-try failing with Ember 3.27 #71

Open
nwhittaker opened this issue May 21, 2021 · 4 comments
Open

Ember-try failing with Ember 3.27 #71

nwhittaker opened this issue May 21, 2021 · 4 comments

Comments

@nwhittaker
Copy link

nwhittaker commented May 21, 2021

Running ember try:one ember-release in the ember-cli-amd project is currently producing many test failures (or otherwise craft and run a scenario that pulls in the 3.27 version of Ember).

If you craft and run a scenario that pulls in the previous 3.26 version of Ember, the tests pass.

It looks like the upcoming 3.27 release of Ember includes some changes to the Ember loader which may be the culprit: emberjs/ember.js#19390.

Test run output
Built project successfully. Stored in "/var/folders/9l/vmkxx6gs34b7tzz97z4msclm0000gn/T/tests-dist-2021427-23240-1v5h9yc.wx24".
not ok 1 Chrome 90.0 - [undefined ms] - Global error: Script error. at , line 0
    ---
        browser log: |
            {"type":"error","text":"Script error. at , line 0\n","testContext":{}}
    ...
not ok 2 Chrome 90.0 - [undefined ms] - Global error: Script error. at , line 0
    ---
        browser log: |
            {"type":"error","text":"[object Object]"}
            {"type":"log","text":"src: dojoLoader"}
            {"type":"log","text":"info: [object Object]"}
            {"type":"log","text":"."}
            {"type":"error","text":"[object Object]"}
            {"type":"log","text":"src: dojoLoader"}
            {"type":"log","text":"info: [object Object]"}
            {"type":"log","text":"."}
            {"type":"error","text":"[object Object]"}
            {"type":"log","text":"src: dojoLoader"}
            {"type":"log","text":"info: [object Object]"}
            {"type":"log","text":"."}
            {"type":"error","text":"[object Object]"}
            {"type":"log","text":"src: dojoLoader"}
            {"type":"log","text":"info: [object Object]"}
            {"type":"log","text":"."}
            {"type":"error","text":"[object Object]"}
            {"type":"log","text":"src: dojoLoader"}
            {"type":"log","text":"info: [object Object]"}
            {"type":"log","text":"."}
            {"type":"error","text":"[object Object]"}
            {"type":"log","text":"src: dojoLoader"}
            {"type":"log","text":"info: [object Object]"}
            {"type":"log","text":"."}
            {"type":"error","text":"[object Object]"}
            {"type":"log","text":"src: dojoLoader"}
            {"type":"log","text":"info: [object Object]"}
            {"type":"log","text":"."}
            {"type":"error","text":"[object Object]"}
            {"type":"log","text":"src: dojoLoader"}
            {"type":"log","text":"info: [object Object]"}
            {"type":"log","text":"."}
            {"type":"error","text":"[object Object]"}
            {"type":"log","text":"src: dojoLoader"}
            {"type":"log","text":"info: [object Object]"}
            {"type":"log","text":"."}
            {"type":"error","text":"[object Object]"}
            {"type":"log","text":"src: dojoLoader"}
            {"type":"log","text":"info: [object Object]"}
            {"type":"log","text":"."}
            {"type":"error","text":"[object Object]"}
            {"type":"log","text":"src: dojoLoader"}
            {"type":"log","text":"info: [object Object]"}
            {"type":"log","text":"."}
            {"type":"error","text":"[object Object]"}
            {"type":"log","text":"src: dojoLoader"}
            {"type":"log","text":"info: [object Object]"}
            {"type":"log","text":"."}
            {"type":"error","text":"[object Object]"}
            {"type":"log","text":"src: dojoLoader"}
            {"type":"log","text":"info: [object Object]"}
            {"type":"log","text":"."}
            {"type":"error","text":"[object Object]"}
            {"type":"log","text":"src: dojoLoader"}
            {"type":"log","text":"info: [object Object]"}
            {"type":"log","text":"."}
            {"type":"error","text":"[object Object]"}
            {"type":"log","text":"src: dojoLoader"}
            {"type":"log","text":"info: [object Object]"}
            {"type":"log","text":"."}
            {"type":"error","text":"[object Object]"}
            {"type":"log","text":"src: dojoLoader"}
            {"type":"log","text":"info: [object Object]"}
            {"type":"log","text":"."}
            {"type":"error","text":"[object Object]"}
            {"type":"log","text":"src: dojoLoader"}
            {"type":"log","text":"info: [object Object]"}
            {"type":"log","text":"."}
            {"type":"error","text":"[object Object]"}
            {"type":"log","text":"src: dojoLoader"}
            {"type":"log","text":"info: [object Object]"}
            {"type":"log","text":"."}
            {"type":"error","text":"[object Object]"}
            {"type":"log","text":"src: dojoLoader"}
            {"type":"log","text":"info: [object Object]"}
            {"type":"log","text":"."}
            {"type":"error","text":"[object Object]"}
            {"type":"log","text":"src: dojoLoader"}
            {"type":"log","text":"info: [object Object]"}
            {"type":"log","text":"."}
            {"type":"error","text":"[object Object]"}
            {"type":"log","text":"src: dojoLoader"}
            {"type":"log","text":"info: [object Object]"}
            {"type":"log","text":"."}
            {"type":"error","text":"[object Object]"}
            {"type":"log","text":"src: dojoLoader"}
            {"type":"log","text":"info: [object Object]"}
            {"type":"log","text":"."}
            {"type":"error","text":"[object Object]"}
            {"type":"log","text":"src: dojoLoader"}
            {"type":"log","text":"info: [object Object]"}
            {"type":"log","text":"."}
            {"type":"error","text":"[object Object]"}
            {"type":"log","text":"src: dojoLoader"}
            {"type":"log","text":"info: [object Object]"}
            {"type":"log","text":"."}
            {"type":"error","text":"[object Object]"}
            {"type":"log","text":"src: dojoLoader"}
            {"type":"log","text":"info: [object Object]"}
            {"type":"log","text":"."}
            {"type":"error","text":"[object Object]"}
            {"type":"log","text":"src: dojoLoader"}
            {"type":"log","text":"info: [object Object]"}
            {"type":"log","text":"."}
            {"type":"error","text":"[object Object]"}
            {"type":"log","text":"src: dojoLoader"}
            {"type":"log","text":"info: [object Object]"}
            {"type":"log","text":"."}
            {"type":"error","text":"[object Object]"}
            {"type":"log","text":"src: dojoLoader"}
            {"type":"log","text":"info: [object Object]"}
            {"type":"log","text":"."}
            {"type":"error","text":"[object Object]"}
            {"type":"log","text":"src: dojoLoader"}
            {"type":"log","text":"info: [object Object]"}
            {"type":"log","text":"."}
            {"type":"error","text":"[object Object]"}
            {"type":"log","text":"src: dojoLoader"}
            {"type":"log","text":"info: [object Object]"}
            {"type":"log","text":"."}
            {"type":"error","text":"[object Object]"}
            {"type":"log","text":"src: dojoLoader"}
            {"type":"log","text":"info: [object Object]"}
            {"type":"log","text":"."}
            {"type":"error","text":"[object Object]"}
            {"type":"log","text":"src: dojoLoader"}
            {"type":"log","text":"info: [object Object]"}
            {"type":"log","text":"."}
            {"type":"error","text":"[object Object]"}
            {"type":"log","text":"src: dojoLoader"}
            {"type":"log","text":"info: [object Object]"}
            {"type":"log","text":"."}
            {"type":"error","text":"[object Object]"}
            {"type":"log","text":"src: dojoLoader"}
            {"type":"log","text":"info: [object Object]"}
            {"type":"log","text":"."}
            {"type":"error","text":"[object Object]"}
            {"type":"log","text":"src: dojoLoader"}
            {"type":"log","text":"info: [object Object]"}
            {"type":"log","text":"."}
            {"type":"error","text":"[object Object]"}
            {"type":"log","text":"src: dojoLoader"}
            {"type":"log","text":"info: [object Object]"}
            {"type":"log","text":"."}
            {"type":"error","text":"[object Object]"}
            {"type":"log","text":"src: dojoLoader"}
            {"type":"log","text":"info: [object Object]"}
            {"type":"log","text":"."}
            {"type":"error","text":"[object Object]"}
            {"type":"log","text":"src: dojoLoader"}
            {"type":"log","text":"info: [object Object]"}
            {"type":"log","text":"."}
            {"type":"error","text":"Script error. at , line 0\n","testContext":{"state":"complete"}}
    ...
not ok 3 Chrome 90.0 - [undefined ms] - Global error: Uncaught Error: Could not find module `ember-resolver` imported from `dummy/app` at http://localhost:7357/assets/vendor.js, line 259
    ---
        browser log: |
            {"type":"error","text":"Uncaught Error: Could not find module `ember-resolver` imported from `dummy/app` at http://localhost:7357/assets/vendor.js, line 259\n","testContext":{"state":"complete"}}
    ...
not ok 4 Chrome 90.0 - [undefined ms] - Global error: Uncaught Error: Could not find module `@ember/test-helpers` imported from `dummy/tests/test-helper` at http://localhost:7357/assets/vendor.js, line 259
    ---
        browser log: |
            {"type":"error","text":"Uncaught Error: Could not find module `@ember/test-helpers` imported from `dummy/tests/test-helper` at http://localhost:7357/assets/vendor.js, line 259\n","testContext":{"state":"complete"}}
    ...
not ok 5 Chrome 90.0 - [undefined ms] - Global error: Uncaught ReferenceError: Ember is not defined at http://localhost:7357/assets/after-amd-loading-tests.js, line 1
    ---
        browser log: |
            {"type":"error","text":"Uncaught ReferenceError: Ember is not defined at http://localhost:7357/assets/after-amd-loading-tests.js, line 1\n","testContext":{"state":"complete"}}
    ...
ffaubry added a commit that referenced this issue Dec 23, 2021
@ffaubry
Copy link
Member

ffaubry commented Dec 23, 2021

@nwhittaker Could you try the commit eac7d94?
I have a fix. Not really elegant but it works.
I'm hoping with Ember 4 we will not need AMD anymore. :)

@nwhittaker
Copy link
Author

Thanks for looking at this @ffaubry. I ran an ember-try scenario for 3.27.5 with the resulting output:

Built project successfully. Stored in "/var/folders/9l/vmkxx6gs34b7tzz97z4msclm0000gn/T/tests-dist-20211123-45394-1jhzk8m.20pm".
not ok 1 Chrome 96.0 - [undefined ms] - Global error: Script error. at , line 0
    ---
        browser log: |
            {"type":"error","text":"Script error. at , line 0\n","testContext":{}}
    ...

1..1
# tests 1
# pass  0
# skip  0
# todo  0
# fail  1
Testem finished with non-zero exit code. Tests failed.

A vast improvement, but still one test failure. Not sure what that one's about.

@ffaubry
Copy link
Member

ffaubry commented Dec 28, 2021

@nwhittaker Did you run these tests against your app?
On our side, this commit fixes all ArcGIS Dashboards issues.
The log above is not really narrowing done the issue.
Would you be able to copy paste the test code?
Or few lines where this is failing at?

@nwhittaker
Copy link
Author

@ffaubry, I think there's some confusion. I ran ember try in this repo for Ember 3.27 -- not in the context of an app. The log is showing a failure for this repo's acceptance test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants