Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

input-date-picker, input-time-picker and list not updating messages when lang changes #9268

Closed
2 of 6 tasks
jcfranco opened this issue May 6, 2024 · 2 comments
Closed
2 of 6 tasks

input-date-picker, input-time-picker and list not updating messages when lang changes #9268

jcfranco opened this issue May 6, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2024-05-28 - May ...

Comments

@jcfranco
Copy link
Member

jcfranco commented May 6, 2024 •
edited

Check existing issues

Actual Behavior

input-date-picker, input-time-picker and list are not updating messages when the locale changes (per t9n's doc).

Expected Behavior

The internal labels to be translated after changing locale.

Reproduction Sample

https://codepen.io/jcfranco/pen/xxevvbE
https://codepen.io/jcfranco/pen/KKYOYzj
https://codepen.io/jcfranco/pen/ExJqJeX

Reproduction Steps

  1. Open provided codepen and see the console
  2. Note how both EN and ES locales show the same value for the internal labels

Reproduction Version

2.18.0

Relevant Info

No response

Regression?

No response

Priority impact

p4 - not time sensitive

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (dev)
@jcfranco jcfranco added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. estimate - 2 Small fix or update, may require updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library labels May 6, 2024
@github-actions github-actions bot added the impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive label May 6, 2024
@jcfranco jcfranco self-assigned this May 6, 2024
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. Calcite (dev) Issues logged by Calcite developers. labels May 6, 2024
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels May 6, 2024
@jcfranco jcfranco added this to the 2024-05-28 - May Main Release milestone May 6, 2024
@jcfranco jcfranco mentioned this issue May 6, 2024
Merged
@jcfranco jcfranco changed the title input-time-picker not updating messages when lang changes input-time-picker and list not updating messages when lang changes May 6, 2024
@jcfranco jcfranco changed the title input-time-picker and list not updating messages when lang changes input-date-picker, input-time-picker and list not updating messages when lang changes May 7, 2024
jcfranco added a commit that referenced this issue May 8, 2024
@jcfranco
fix(input-date-picker, input-time-picker, list): ensure lang change u…
0213d35 
…pdates messages (#9265)

**Related Issue:** #9268

## Summary

This fixes the implementation of `t9n` in the following:

* `input-date-picker`/`input-time-picker` – adds missing
`updateMessages` call on locale change
* `list`– implements `LocalizedComponent` ([required by
`t9n`](https://github.com/Esri/calcite-design-system/blob/main/packages/calcite-components/src/utils/t9n.ts#L105)).
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels May 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned jcfranco May 10, 2024
@DitwanP
Copy link
Contributor

DitwanP commented May 22, 2024

🍮 Verified on 2.9.0-next.18

@DitwanP DitwanP closed this as completed May 22, 2024
@DitwanP DitwanP removed the 3 - installed Issues that have been merged to master branch and are ready for final confirmation. label May 22, 2024
@DitwanP DitwanP added the 4 - verified Issues that have been released and confirmed resolved. label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2024-05-28 - May Main Release
Development

No branches or pull requests
3 participants
@jcfranco @geospatialem @DitwanP