Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auto Benchmarks] - Flamegraphing with auto benchmarking #3186

Open
dailinsubjam opened this issue May 17, 2024 · 0 comments
Open

[Auto Benchmarks] - Flamegraphing with auto benchmarking #3186

dailinsubjam opened this issue May 17, 2024 · 0 comments

Comments

@dailinsubjam
Copy link
Contributor

What is this task and why do we need to work on it?

To help to answer why are we not getting better throughput/latency, we want to do flamegraphing for some runs.

What work will need to be done to complete this task?

Write scripts to generate flamegraph automatically.

Are there any other details to include?

If you want to profile the code, it's not too hard to set up, you would just hook it up to here: https://github.com/flamegraph-rs/flamegraph?tab=readme-ov-file#installation and make sure you copy the RUSTFLAGS from the justfile when running.
You would end up with a command like RUSTFLAGS='--cfg async_executor_impl="async-std" --cfg async_channel_impl="async-std"' sudo cargo flamegraph --test TEST_NAME.
If it's a cargo subcommand you can do just cargo flamegraph (defaults to async-std).
[Copy-Pasted from Zulip]

What are the acceptance criteria to close this issue?

Flamegraphing is integrated into the scripts or could be easily run when we want one for a benchmark run.

Branch work will be merged to (if not the default branch)

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant