Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CX_CLEANUP] - Diverge the QuorumProposal task #3171

Closed
4 tasks
Tracked by #3265
jparr721 opened this issue May 15, 2024 · 0 comments · Fixed by #3151
Closed
4 tasks
Tracked by #3265

[CX_CLEANUP] - Diverge the QuorumProposal task #3171

jparr721 opened this issue May 15, 2024 · 0 comments · Fixed by #3151

Comments

@jparr721
Copy link
Contributor

jparr721 commented May 15, 2024

What is this task and why do we need to work on it?

Right now the quorum proposal task relies on calling the existing consensus functions, but isolates the call site so that way it can exist in an idempotent manner. This has created some issues due to the need to keep backwards compatibility with the consensus task. Instead, we will author our own new logic and only reuse functions that have limited scope.

What work will need to be done to complete this task?

  • Make a new Quorum Proposal Task module which will hold all relevant logic for that task
  • Fully remove all references to the old consensus task unless the functionality will live on in the new tasks
  • Fully test and evaluate all new code in the unit testing suite to ensure that all expected behaviors are understood.
  • Update the design document in notion with the architecture and event diagram.

Are there any other details to include?

No response

What are the acceptance criteria to close this issue?

All tests must pass.

Branch work will be merged to (if not the default branch)

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant