Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CX_CLEANUP] - Create a new pared down Consensus module. #3170

Closed
2 tasks
Tracked by #2356
jparr721 opened this issue May 15, 2024 · 1 comment
Closed
2 tasks
Tracked by #2356

[CX_CLEANUP] - Create a new pared down Consensus module. #3170

jparr721 opened this issue May 15, 2024 · 1 comment

Comments

@jparr721
Copy link
Contributor

What is this task and why do we need to work on it?

We need a new separate consensus module that will exist alongside the existing consensus module to achieve our goals of removing the old logic. This will enable us to build the features in isolation without needing to fight against merge conflicts and bug fixes as we stabilize for Cappuccino.

What work will need to be done to complete this task?

  • Create the new Consensus task under the name consensus2.
  • Add a flag toggle to hotshot/lib.rs to enable it alongside the other dependency tasks.

Are there any other details to include?

This one might not need exhaustive testing yet since it should essentially just handle vote tabulation, which we can definitely take 1:1 with the existing consensus task.

What are the acceptance criteria to close this issue?

New task is added and the tests pass.

Branch work will be merged to (if not the default branch)

No response

@shenkeyao
Copy link
Member

Closed by #3149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants