Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New objenesis version excludes 60% of android devices #691

Closed
Erhannis opened this issue Sep 2, 2019 · 6 comments · Fixed by #814
Closed

New objenesis version excludes 60% of android devices #691

Erhannis opened this issue Sep 2, 2019 · 6 comments · Fixed by #814

Comments

@Erhannis
Copy link

Erhannis commented Sep 2, 2019

The version increase of objenesis to 3.0.1, in kryo 5.0.0-RC3, yields the following error in my Android project:

MethodHandle.invoke and MethodHandle.invokeExact are only supported starting with Android O (--min-api 26)

By the numbers at https://developer.android.com/about/dashboards, only ~40% of devices are at API 26 and above, as of May 2019. (Some of the devices, like mine, have no system updates available, and likely never will.) Requiring your users to drop 60% of THEIR users seems like a good way to lock people into an old version of your library (and also I'd prefer I didn't get locked into an old version of your library on my own projects).

@NathanSweet
Copy link
Member

Sorry for the late response!

I didn't realize this was the case. Maybe you could provide a PR to go back to the latest reasonable version of objenesis?

@theigl
Copy link
Collaborator

theigl commented May 30, 2020

@Erhannis: You always override the dependency version of Objenesis back to version 2.6 in your project. Kryo is still fully compatible with 2.6.

@beyondeye
Copy link

There is a relatively new open issue in objenesis (easymock/objenesis#79). Apparently they are planning for a fix soon

@theigl
Copy link
Collaborator

theigl commented Nov 27, 2020

There is a detailed discussion of these issues over at Mockito: mockito/mockito#2007

@JBou
Copy link

JBou commented Mar 26, 2021

The upstream issue has been closed. It has been fixed in objenesis 3.2
easymock/objenesis#79

@theigl
Copy link
Collaborator

theigl commented Mar 26, 2021

Can someone verify that this really resolves the problem? If so, I'll bump the dependency.

theigl added a commit that referenced this issue Mar 31, 2021
theigl added a commit that referenced this issue Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

5 participants