Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add issue / pull request number option #465

Open
miguelaferreira opened this issue Jun 6, 2023 · 3 comments
Open

Add issue / pull request number option #465

miguelaferreira opened this issue Jun 6, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@miguelaferreira
Copy link

Thanks for this really nice action! We have been using it a lot and really like it.

We've started to use this action to post results of deployment tests, and while we get the test results in the github action workflow summary, We don't get them in the pull requests nor issues that trigger the deployment.

We have two use cases:

  1. Deploy a release candidate from a PR:
  • On the PR we add a label deploy, that run a workflow that creates a release candidate git tag;
  • Then the tag triggers a deployment workflow that deploys the release candidate;
  • After deployment we run a tool that tests it;
  • That tool produces an XML output that this action can read;
  • Then the action posts the test results in the workflow summary;
  • What we're missing is: to have the action also posts the test results in the PR where it all started to begin with.
  1. Deploy a final release from an issue:
  • Once code gets merged to main branch, a workflow creates a final release git tag;
  • That tag triggers the creation of a deployment issue, basically an issue with a specific format that we use to deploy final releases to different environments in sequence;
  • Once we comment deploy tst on the deployment issue, a workflow starts the deployment of the release to our TST environment.
  • After deployment we run a tool that tests it;
  • That tool produces an XML output that this action can read;
  • Then the action posts the test results in the workflow summary;
  • What I'm missing is: to have the action also posts the test results in the PR where it all started to begin with.

So, what we are asking in this issue is to have a way to provide the issue/pr ID to the action, in order for it to post to issues/pull requests (respectively).

@EnricoMi
Copy link
Owner

EnricoMi commented Jun 6, 2023

Very interesting use case. I agree, providing the issue / pr number explicitly should make this work. Commenting on an issue might need some changes, maybe it just works (as pull requests are issues).

@EnricoMi EnricoMi added the enhancement New feature or request label Jun 6, 2023
@EnricoMi EnricoMi changed the title Provide issue or pull request input Add issue / pull request number option Jun 6, 2023
@EnricoMi
Copy link
Owner

EnricoMi commented Jun 6, 2023

Would you consider configuring multiple issues or pull requests useful?

@miguelaferreira
Copy link
Author

Thanks for the quick reply @EnricoMi. For our use cases there is no need to comment on multiple issues/PRs.

Just thinking out loud here, if we had that need we could prolly do something with a matrix strategy, or setup a job that executes the action multiple times (maybe even with conditions).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants