Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check-run HTML URL to JSON output. #311

Merged

Conversation

danxmoran
Copy link
Contributor

Closes #310

Copy link
Owner

@EnricoMi EnricoMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a minor formatting thing.

I have created PR #1 in your repo. If you activate GitHub actions for that repo, your next commit will run the CI and actually execute the action on that PR. That is the best way to test this. No need to merge that into your master. I cannot test it in my repo before merging.

python/test/test_publisher.py Outdated Show resolved Hide resolved
@danxmoran danxmoran force-pushed the danxmoran/output-json-include-check-url branch from df2c341 to 023264f Compare June 24, 2022 16:56
@danxmoran
Copy link
Contributor Author

@EnricoMi tests are running on danxmoran#1 now, thanks for the pointers!

@EnricoMi
Copy link
Owner

@github-actions
Copy link

Test Results (reference)

       69 files  ±0         69 suites  ±0   17m 17s ⏱️ +47s
     309 tests ±0       309 ✔️ ±0      0 💤 ±0  0 ±0 
21 321 runs  ±0  20 781 ✔️ ±0  540 💤 ±0  0 ±0 

Results for commit 023264f. ± Comparison against base commit 2934772.

@EnricoMi EnricoMi merged commit d624a68 into EnricoMi:master Jun 24, 2022
@EnricoMi
Copy link
Owner

Thanks for the contribution!

@danxmoran danxmoran deleted the danxmoran/output-json-include-check-url branch July 11, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include check URL in JSON output
2 participants