Add support for TRX files #287

EnricoMi · 2022-05-23T15:50:42Z

Fixes #279.

sonatype-lift · 2022-05-23T15:53:08Z

python/publish/trx.py

+from typing import Iterable, Tuple, Union
+
+from junitparser import JUnitXml
+from lxml import etree


blacklist: Using etree to parse untrusted XML data is known to be vulnerable to XML attacks. Replace etree with the equivalent defusedxml package.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-23T15:53:09Z

python/publish/trx.py

+            return Exception(f'File is empty.')
+
+        try:
+            trx = etree.parse(path)


blacklist: Using lxml.etree.parse to parse untrusted XML data is known to be vulnerable to XML attacks. Replace lxml.etree.parse with its defusedxml equivalent function.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

python/publish/trx.py

sonatype-lift · 2022-05-23T15:53:11Z

python/publish/trx.py

+from typing import Iterable, Tuple, Union
+
+from junitparser import JUnitXml
+from lxml import etree


opt.semgrep.python.lang.security.use-defused-xml.use-defused-xml: Found use of the native Python XML libraries, which is vulnerable to XML external entity (XXE)
attacks. The Python documentation recommends the 'defusedxml' library instead if the XML being
loaded is untrusted.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

github-actions · 2022-05-23T15:58:00Z

Test Results (macOS python installed)

      69 files ±    0       69 suites ±0 24m 4s ⏱️ + 7m 39s
    300 tests -     8     300 ✔️ -     8     0 💤 ±0 0 ❌ ±0
20 700 runs - 552 20 160 ✔️ - 552 540 💤 ±0 0 ❌ ±0

Results for commit 7067fa3. ± Comparison against base commit b776d2f.

♻️ This comment has been updated with latest results.

github-actions · 2022-05-23T15:58:17Z

Test Results (macOS python 3.6)

      69 files ±    0       69 suites ±0 24m 4s ⏱️ + 7m 39s
    300 tests -     8     300 ✔️ -     8     0 💤 ±0 0 ❌ ±0
20 700 runs - 552 20 160 ✔️ - 552 540 💤 ±0 0 ❌ ±0

Results for commit 7067fa3. ± Comparison against base commit b776d2f.

♻️ This comment has been updated with latest results.

github-actions · 2022-05-23T15:58:22Z

Test Results (Dockerfile)

      69 files ±    0       69 suites ±0 24m 4s ⏱️ + 7m 39s
    300 tests -     8     300 ✔️ -     8     0 💤 ±0 0 ❌ ±0
20 700 runs - 552 20 160 ✔️ - 552 540 💤 ±0 0 ❌ ±0

Results for commit 7067fa3. ± Comparison against base commit b776d2f.

♻️ This comment has been updated with latest results.

github-actions · 2022-05-23T15:58:30Z

Test Results (Docker Image)

      69 files ±    0       69 suites ±0 24m 4s ⏱️ + 7m 39s
    300 tests -     8     300 ✔️ -     8     0 💤 ±0 0 ❌ ±0
20 700 runs - 552 20 160 ✔️ - 552 540 💤 ±0 0 ❌ ±0

Results for commit 7067fa3. ± Comparison against base commit b776d2f.

♻️ This comment has been updated with latest results.

github-actions · 2022-05-23T15:58:39Z

Test Results (Test Files)

    35 files +    9       4 errors 32 suites +9 39m 52s ⏱️ +31s
1 214 tests +935 1 112 ✔️ +884 57 💤 +37 39 ❌ +14 6 🔥 ±0
1 397 runs +947 1 246 ✔️ +888 96 💤 +39 48 ❌ +20 7 🔥 ±0

For more details on these parsing errors, failures and errors, see this check.

Results for commit 7067fa3. ± Comparison against base commit b776d2f.

♻️ This comment has been updated with latest results.

github-actions · 2022-05-23T15:58:51Z

Test Results (Linux python 3.6)

      69 files ±    0       69 suites ±0 24m 4s ⏱️ + 7m 39s
    300 tests -     8     300 ✔️ -     8     0 💤 ±0 0 ❌ ±0
20 700 runs - 552 20 160 ✔️ - 552 540 💤 ±0 0 ❌ ±0

Results for commit 7067fa3. ± Comparison against base commit b776d2f.

♻️ This comment has been updated with latest results.

github-actions · 2022-05-23T15:58:55Z

Test Results (Linux python installed)

      69 files ±    0       69 suites ±0 24m 4s ⏱️ + 7m 39s
    300 tests -     8     300 ✔️ -     8     0 💤 ±0 0 ❌ ±0
20 700 runs - 552 20 160 ✔️ - 552 540 💤 ±0 0 ❌ ±0

Results for commit 7067fa3. ± Comparison against base commit b776d2f.

♻️ This comment has been updated with latest results.

github-actions · 2022-05-23T15:59:24Z

Test Results (macOS 12 python installed)

      69 files ±    0       69 suites ±0 24m 4s ⏱️ + 7m 39s
    300 tests -     8     300 ✔️ -     8     0 💤 ±0 0 ❌ ±0
20 700 runs - 552 20 160 ✔️ - 552 540 💤 ±0 0 ❌ ±0

Results for commit 7067fa3. ± Comparison against base commit b776d2f.

♻️ This comment has been updated with latest results.

github-actions · 2022-05-23T15:59:32Z

Test Results (Linux 22.04 python installed)

      69 files ±    0       69 suites ±0 24m 4s ⏱️ + 7m 39s
    300 tests -     8     300 ✔️ -     8     0 💤 ±0 0 ❌ ±0
20 700 runs - 552 20 160 ✔️ - 552 540 💤 ±0 0 ❌ ±0

Results for commit 7067fa3. ± Comparison against base commit b776d2f.

♻️ This comment has been updated with latest results.

github-actions · 2022-05-23T16:02:11Z

Test Results (Windows python installed)

      69 files ±    0       69 suites ±0 24m 4s ⏱️ + 7m 39s
    300 tests -     8     300 ✔️ -     8     0 💤 ±0 0 ❌ ±0
20 700 runs - 552 20 160 ✔️ - 552 540 💤 ±0 0 ❌ ±0

Results for commit 7067fa3. ± Comparison against base commit b776d2f.

♻️ This comment has been updated with latest results.

github-actions · 2022-05-23T16:03:09Z

Test Results (reference)

      69 files ±    0       69 suites ±0 24m 4s ⏱️ + 7m 39s
    300 tests -     8     300 ✔️ -     8     0 💤 ±0 0 ❌ ±0
20 700 runs - 552 20 160 ✔️ - 552 540 💤 ±0 0 ❌ ±0

Results for commit 7067fa3. ± Comparison against base commit b776d2f.

This pull request removes 15 and adds 7 tests. Note that renamed tests count towards both.

test_junit.TestJunit ‑ test_parse_junit_xml_file_with_disabled_tests
test_junit.TestJunit ‑ test_parse_junit_xml_files_with_corrupt_xml_file
test_junit.TestJunit ‑ test_parse_junit_xml_files_with_empty_file
test_junit.TestJunit ‑ test_parse_junit_xml_files_with_horovod_file
test_junit.TestJunit ‑ test_parse_junit_xml_files_with_minimal_attributes_file
test_junit.TestJunit ‑ test_parse_junit_xml_files_with_no_attributes_file
test_junit.TestJunit ‑ test_parse_junit_xml_files_with_no_files
test_junit.TestJunit ‑ test_parse_junit_xml_files_with_non_existing_file
test_junit.TestJunit ‑ test_parse_junit_xml_files_with_non_junit_file
test_junit.TestJunit ‑ test_parse_junit_xml_files_with_non_xml_file
…

test_action_script.Test ‑ test_get_settings_any_files
test_action_script.Test ‑ test_parse_files
test_action_script.Test ‑ test_parse_files_no_matches
test_junit.TestJunit ‑ test_parse_and_process_files
test_junit.TestJunit ‑ test_process_parse_junit_xml_files_with_no_files
test_junit.TestJunit ‑ test_process_parse_junit_xml_files_with_time_factor
test_trx.TestTrx ‑ test_parse_and_process_files

♻️ This comment has been updated with latest results.

sonatype-lift · 2022-05-24T12:13:01Z

python/test/test_trx.py

+
+    def test_transform(self):
+        result_file = str(test_files_path / 'mstest.trx')
+        trx = etree.parse(str(result_file))


blacklist: Using lxml.etree.parse to parse untrusted XML data is known to be vulnerable to XML attacks. Replace lxml.etree.parse with its defusedxml equivalent function.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-24T12:13:03Z

python/test/test_trx.py

+import pathlib
+import unittest
+
+from lxml import etree


blacklist: Using etree to parse untrusted XML data is known to be vulnerable to XML attacks. Replace etree with the equivalent defusedxml package.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

…t name

…saving switch

github-actions · 2022-06-21T10:34:39Z

Test Results (setup-python)

      69 files ±    0       69 suites ±0 24m 4s ⏱️ + 7m 39s
    300 tests -     8     300 ✔️ -     8     0 💤 ±0 0 ❌ ±0
20 700 runs - 552 20 160 ✔️ - 552 540 💤 ±0 0 ❌ ±0

Results for commit 7067fa3. ± Comparison against base commit b776d2f.

EnricoMi force-pushed the branch-add-trx branch from f1e4dab to cd3c85c Compare May 23, 2022 15:51

sonatype-lift bot reviewed May 23, 2022

View reviewed changes

python/publish/trx.py Show resolved Hide resolved

sonatype-lift bot reviewed May 23, 2022

View reviewed changes

This comment has been minimized.

Sign in to view

EnricoMi force-pushed the branch-add-trx branch from cd3c85c to 44bf308 Compare May 23, 2022 16:03

This comment has been minimized.

Sign in to view

EnricoMi force-pushed the branch-add-trx branch from 346501d to 2f23332 Compare May 23, 2022 16:58

This comment has been minimized.

Sign in to view

EnricoMi force-pushed the master branch from 2f5edfc to 3a1f2bd Compare May 23, 2022 17:14

EnricoMi force-pushed the branch-add-trx branch from 2f23332 to 8faa2d8 Compare May 23, 2022 17:14

This comment has been minimized.

Sign in to view

EnricoMi force-pushed the master branch from 3a1f2bd to b8402a4 Compare May 23, 2022 18:16

EnricoMi marked this pull request as ready for review May 23, 2022 20:09

EnricoMi force-pushed the branch-add-trx branch from 8faa2d8 to 817c56d Compare May 23, 2022 20:11

This comment has been minimized.

Sign in to view

sonatype-lift bot reviewed May 24, 2022

View reviewed changes

EnricoMi added 26 commits June 21, 2022 12:17

Add TRX test

b480292

Add trx files to publish-test-files

e516c7d

Move test files into sub-directories

90aa3ec

Parse all example files and compare to expectations

e896c0a

Run tests on all example test result files

82a4129

Add missing results file

9c533d7

Fix automated example file tests on Windows

c43424a

Make exception string work for 3.6

6c978a9

Test parse and process example files with locales

72f702d

Fixing duration number format in trx xslt

2220626

Remove MESSAGE and STACK TRACE from xslt

5a04a32

Use failure template in trx-to-junit.xslt

519a09a

Automated example file test supersedes transformation test

23852ba

Make test_files_path private so it is not considered a test

9ecb571

Allow for NaN time values

1a33f55

Add skipped results

1a48953

Extract class name when there is no comma, remove class name from tes…

69ff412

…t name

Do not produce NaN times

9ceb86e

Push UnitTest selection by id into xpath select

c66c896

Update stats over all test example files

9e06502

Make duration from timestamps work with date boundaries and daylight …

e1fe3d1

…saving switch

Make duration from timestamps work beyond 2038 (32-bit seconds)

f4b1f39

Guard against NaN suite times

a9af6a2

Fix single file publish

e9d990a

Some changes in README.md got lost, added again

0bcc218

Introduce JUnitTreeOrException and ParsedJUnitFile

7067fa3

EnricoMi force-pushed the branch-add-trx branch from 2a34cfa to 7067fa3 Compare June 21, 2022 10:18

EnricoMi merged commit e633876 into devel-2.0 Jun 21, 2022

EnricoMi deleted the branch-add-trx branch June 21, 2022 10:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for TRX files #287

Add support for TRX files #287

EnricoMi commented May 23, 2022 •

edited

sonatype-lift bot May 23, 2022

sonatype-lift bot May 23, 2022

sonatype-lift bot May 23, 2022

This comment has been minimized.

github-actions bot commented May 23, 2022 •

edited

github-actions bot commented May 23, 2022 •

edited

github-actions bot commented May 23, 2022 •

edited

github-actions bot commented May 23, 2022 •

edited

github-actions bot commented May 23, 2022 •

edited

github-actions bot commented May 23, 2022 •

edited

github-actions bot commented May 23, 2022 •

edited

github-actions bot commented May 23, 2022 •

edited

github-actions bot commented May 23, 2022 •

edited

github-actions bot commented May 23, 2022 •

edited

github-actions bot commented May 23, 2022 •

edited

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

sonatype-lift bot May 24, 2022

sonatype-lift bot May 24, 2022

github-actions bot commented Jun 21, 2022

Add support for TRX files #287

Add support for TRX files #287

Conversation

EnricoMi commented May 23, 2022 • edited

sonatype-lift bot May 23, 2022

Choose a reason for hiding this comment

sonatype-lift bot May 23, 2022

Choose a reason for hiding this comment

sonatype-lift bot May 23, 2022

Choose a reason for hiding this comment

This comment has been minimized.

github-actions bot commented May 23, 2022 • edited

Test Results (macOS python installed)

github-actions bot commented May 23, 2022 • edited

Test Results (macOS python 3.6)

github-actions bot commented May 23, 2022 • edited

Test Results (Dockerfile)

github-actions bot commented May 23, 2022 • edited

Test Results (Docker Image)

github-actions bot commented May 23, 2022 • edited

Test Results (Test Files)

github-actions bot commented May 23, 2022 • edited

Test Results (Linux python 3.6)

github-actions bot commented May 23, 2022 • edited

Test Results (Linux python installed)

github-actions bot commented May 23, 2022 • edited

Test Results (macOS 12 python installed)

github-actions bot commented May 23, 2022 • edited

Test Results (Linux 22.04 python installed)

github-actions bot commented May 23, 2022 • edited

Test Results (Windows python installed)

github-actions bot commented May 23, 2022 • edited

Test Results (reference)

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

sonatype-lift bot May 24, 2022

Choose a reason for hiding this comment

sonatype-lift bot May 24, 2022

Choose a reason for hiding this comment

github-actions bot commented Jun 21, 2022

Test Results (setup-python)

EnricoMi commented May 23, 2022 •

edited

github-actions bot commented May 23, 2022 •

edited

github-actions bot commented May 23, 2022 •

edited

github-actions bot commented May 23, 2022 •

edited

github-actions bot commented May 23, 2022 •

edited

github-actions bot commented May 23, 2022 •

edited

github-actions bot commented May 23, 2022 •

edited

github-actions bot commented May 23, 2022 •

edited

github-actions bot commented May 23, 2022 •

edited

github-actions bot commented May 23, 2022 •

edited

github-actions bot commented May 23, 2022 •

edited

github-actions bot commented May 23, 2022 •

edited